Tweaks docs to create Istio CRDs first - part 2 #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of knative#717 - get the rest of the install docs Signed-off-by: Doug Davis <dug@us.ibm.com>
knative-prow-robot
added
the
size/M
duglin
commented
Jan 9, 2019
| also included in the `istio.yaml` file, but they are pulled out so that | ||
| the CRD definitions are created first. If you see an error when creating | ||
| resources about an unknown type, run the second `kubectl apply` command | ||
| again. |
Author
There was a problem hiding this comment.
While this file already had a variant of this text, I opted to replace it with the new stuff for consistency.
carieshmarie
approved these changes
Jan 9, 2019
Contributor
carieshmarie
left a comment
carieshmarie
left a comment
There was a problem hiding this comment.
Looks good - thanks!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carieshmarie, duglin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #717 - get the rest of the install docs
Signed-off-by: Doug Davis dug@us.ibm.com