Skip to content

Tweaks docs to create Istio CRDs first - part 2 #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Tweaks docs to create Istio CRDs first - part 2 #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions install/Knative-with-AKS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,15 @@ Knative depends on Istio.

1. Install Istio:
```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio.yaml
```
Note: the resources (CRDs) defined in the `istio-crds.yaml`file are
also included in the `istio.yaml` file, but they are pulled out so that
the CRD definitions are created first. If you see an error when creating
resources about an unknown type, run the second `kubectl apply` command
again.

1. Label the default namespace with `istio-injection=enabled`:

```bash
Expand Down
7 changes: 7 additions & 0 deletions install/Knative-with-GKE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,15 @@ Knative depends on Istio.

1. Install Istio:
```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio.yaml
```
Note: the resources (CRDs) defined in the `istio-crds.yaml`file are
also included in the `istio.yaml` file, but they are pulled out so that
the CRD definitions are created first. If you see an error when creating
resources about an unknown type, run the second `kubectl apply` command
again.

1. Label the default namespace with `istio-injection=enabled`:
```bash
kubectl label namespace default istio-injection=enabled
Expand Down
7 changes: 7 additions & 0 deletions install/Knative-with-Gardener.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,15 @@ Knative depends on Istio.

1. Install Istio:
```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio.yaml
```
Note: the resources (CRDs) defined in the `istio-crds.yaml`file are
also included in the `istio.yaml` file, but they are pulled out so that
the CRD definitions are created first. If you see an error when creating
resources about an unknown type, run the second `kubectl apply` command
again.

2. Label the default namespace with `istio-injection=enabled`:
```bash
kubectl label namespace default istio-injection=enabled
Expand Down
11 changes: 6 additions & 5 deletions install/Knative-with-Minishift.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,14 @@ curl -s https://raw.githubusercontent.com/knative/docs/master/install/scripts/is
1. Run the following to install Istio:

```shell
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \
oc apply -f https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml
```

> **NOTE:** If you get a lot of errors after running the above command like:
> **unable to recognize "STDIN": no matches for kind "Gateway" in version
> "networking.istio.io/v1alpha3"**, just run the command above again, it's
> idempotent and hence objects will be created only once.
Note: the resources (CRDs) defined in the `istio-crds.yaml`file are
also included in the `istio.yaml` file, but they are pulled out so that
the CRD definitions are created first. If you see an error when creating
resources about an unknown type, run the second `kubectl apply` command
again.
Copy link
Author

@duglin duglin Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this file already had a variant of this text, I opted to replace it with the new stuff for consistency.


2. Ensure the istio-sidecar-injector pods runs as provileged:
```shell
Expand Down
7 changes: 7 additions & 0 deletions install/Knative-with-PKS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,15 @@ Containers

1. Install Istio:
```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio.yaml
```
Note: the resources (CRDs) defined in the `istio-crds.yaml`file are
also included in the `istio.yaml` file, but they are pulled out so that
the CRD definitions are created first. If you see an error when creating
resources about an unknown type, run the second `kubectl apply` command
again.

1. Label the default namespace with `istio-injection=enabled`:
```bash
kubectl label namespace default istio-injection=enabled
Expand Down
7 changes: 7 additions & 0 deletions install/Knative-with-any-k8s.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,15 @@ Containers.

1. Install Istio:
```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \
kubectl apply --filename https://raw.githubusercontent.com/knative/serving/v0.2.2/third_party/istio-1.0.2/istio.yaml
```
Note: the resources (CRDs) defined in the `istio-crds.yaml`file are
also included in the `istio.yaml` file, but they are pulled out so that
the CRD definitions are created first. If you see an error when creating
resources about an unknown type, run the second `kubectl apply` command
again.

1. Label the default namespace with `istio-injection=enabled`:
```bash
kubectl label namespace default istio-injection=enabled
Expand Down