Skip to content

Add link to image in Dockerhub #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2019
Merged

Add link to image in Dockerhub #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc9a486
Add link to image in Dockerhub
steren Jan 10, 2019
ca9f76b
also README
steren Jan 10, 2019
4e546c9
Fixes indentation issue causing build test failure
samodell Jan 14, 2019
aa7c0cb
fix bullet list indentation
steren Jan 14, 2019
ff4be63
attempt #2 -- fixing build failure
samodell Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions serving/samples/helloworld-go/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Use the offical Golang image to create a build artifact.
# This is based on Debian and sets the GOPATH to /go.
# https://hub.docker.com/_/golang
FROM golang as builder

# Copy local code to the container image.
Expand Down
10 changes: 5 additions & 5 deletions serving/samples/helloworld-go/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ recreate the source files from this folder.
```docker
# Use the offical Golang image to create a build artifact.
# This is based on Debian and sets the GOPATH to /go.
# https://hub.docker.com/_/golang
FROM golang as builder

# Copy local code to the container image.
Expand Down Expand Up @@ -136,11 +137,10 @@ folder) you're ready to build and deploy the sample app.
```

1. Now that your service is created, Knative will perform the following steps:

- Create a new immutable revision for this version of the app.
- Network programming to create a route, ingress, service, and load balance
for your app.
- Automatically scale your pods up and down (including to zero active pods).
- Create a new immutable revision for this version of the app.
- Network programming to create a route, ingress, service, and load balance
for your app.
- Automatically scale your pods up and down (including to zero active pods).

1. Run the following command to find the external IP address for your service.
The ingress IP for your cluster is returned. If you just created your
Expand Down