Skip to content

v0.3 updates for Gardener, ICP, Minikube, Minishift installs #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2019
Merged

v0.3 updates for Gardener, ICP, Minikube, Minishift installs #775

merged 3 commits into from
Jan 24, 2019

Conversation

@samodell
Copy link
Contributor

@samodell samodell commented Jan 16, 2019

Fixes #740

@samodell
Copy link
Contributor Author

samodell commented Jan 16, 2019

/hold

A couple open questions.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved labels Jan 16, 2019
samodell
samodell commented Jan 16, 2019
View reviewed changes
install/Knative-with-Minishift.md
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \
oc apply -f https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml
kubectl apply --filename https://github.com/knative/serving/releases/download/v0.3.0/istio-crds.yaml && \
oc apply -f https://github.com/knative/serving/releases/download/v0.3.0/istio.yaml
Copy link
Contributor Author

@samodell samodell Jan 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 168 -- when this URL was https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml, the command was oc apply -f instead of kubectl apply --filename. Should I update the command to kubectl apply --filename? Honestly not sure why it wasn't to begin with...

Copy link
Contributor Author

@samodell samodell Jan 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kameshsampath Are you able to answer this question about the Minishift install guide? Looks like you've contributed to this doc in the past.

Copy link
Contributor

@kameshsampath kameshsampath Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samodell - i will check and get back to you on this, i have not tried 0.3.0 yet

Copy link
Contributor Author

@samodell samodell Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kameshsampath FYI, I think we're close to merging in this PR.

install/Knative-with-Minishift.md

```shell
oc apply -f https://storage.googleapis.com/knative-releases/serving/latest/release-no-mon.yaml
oc apply -f https://github.com/knative/serving/releases/download/v0.3.0/serving.yaml \
Copy link
Contributor Author

@samodell samodell Jan 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as above re: oc apply

Copy link
Contributor

@kameshsampath kameshsampath Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samodell - same comment as above

@samodell samodell removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 18, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 19, 2019

@vasu1124: GitHub didn't allow me to request PR reviews from the following users: adracus.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks for housekeeping.
We are re-working the Bouquet addon manager completely and have deprecated that feature for now.
/cc @adracus
The section ## Alternative way to enable Knative with Gardener can be removed for the time being.

I think there already was a comment that the install information is mostly redundant and could be references from one place. The only the valuable info remaining is how to get the initial cluster and what steps are necessary to configure the underlay properly to get istio/knative working orderly. If you are reworking the doc to that target, this Gardener install doc can be minimized further.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carieshmarie carieshmarie added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@knative-prow-robot knative-prow-robot merged commit 8b2eba4 into knative:master Jan 24, 2019
@kameshsampath
Copy link
Contributor

kameshsampath commented Jan 24, 2019

@samodell - sorry to get late on this, oc apply or k apply both can be used interchangably.

@samodell
Copy link
Contributor Author

samodell commented Jan 24, 2019

Great, thanks for the update, @kameshsampath !

@samodell samodell mentioned this pull request Feb 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

2 more reviewers

@kameshsampath kameshsampath kameshsampath left review comments

@vasu1124 vasu1124 vasu1124 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@samodell @knative-prow-robot @kameshsampath @vasu1124 @googlebot @carieshmarie