-
Notifications
You must be signed in to change notification settings - Fork 1.3k
v0.3 updates for Gardener, ICP, Minikube, Minishift installs #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,8 +161,8 @@ curl -s https://raw.githubusercontent.com/knative/docs/master/install/scripts/is | |
| 1. Run the following to install Istio: | ||
|
|
||
| ```shell | ||
| kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml && \ | ||
| oc apply -f https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml | ||
| kubectl apply --filename https://github.com/knative/serving/releases/download/v0.3.0/istio-crds.yaml && \ | ||
| oc apply -f https://github.com/knative/serving/releases/download/v0.3.0/istio.yaml | ||
| ``` | ||
| Note: the resources (CRDs) defined in the `istio-crds.yaml`file are | ||
| also included in the `istio.yaml` file, but they are pulled out so that | ||
|
|
@@ -203,7 +203,8 @@ curl -s https://raw.githubusercontent.com/knative/docs/master/install/scripts/kn | |
| 1. Install Knative serving: | ||
|
|
||
| ```shell | ||
| oc apply -f https://storage.googleapis.com/knative-releases/serving/latest/release-no-mon.yaml | ||
| oc apply -f https://github.com/knative/serving/releases/download/v0.3.0/serving.yaml \ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same concern as above re:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @samodell - same comment as above |
||
| oc apply -f https://github.com/knative/build/releases/download/v0.3.0/build.yaml | ||
| ``` | ||
|
|
||
| 2. Monitor the Knative components until all of the components show a `STATUS` of | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 168 -- when this URL was https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml, the command was
oc apply -finstead ofkubectl apply --filename. Should I update the command tokubectl apply --filename? Honestly not sure why it wasn't to begin with...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kameshsampath Are you able to answer this question about the Minishift install guide? Looks like you've contributed to this doc in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samodell - i will check and get back to you on this, i have not tried 0.3.0 yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kameshsampath FYI, I think we're close to merging in this PR.