Skip to content

fix: do not prompt user if --build diabled#1071

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
lance:lance-693-func-deploy
Jun 16, 2022
Merged

fix: do not prompt user if --build diabled#1071
knative-prow[bot] merged 1 commit intoknative:mainfrom
lance:lance-693-func-deploy

Conversation

@lance
Copy link
Contributor

@lance lance commented Jun 16, 2022

Fixes: #693

/kind fix

Signed-off-by: Lance Ball lball@redhat.com

no longer prompts for image/registry info if `--build disabled` when running `func deploy`

Fixes: knative#693

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested review from matejvasek and salaboy June 16, 2022 20:44
@lance lance self-assigned this Jun 16, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 16, 2022

@lance: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

Details

In response to this:

Fixes: #693

/kind fix

Signed-off-by: Lance Ball lball@redhat.com

no longer prompts for image/registry info if `--build disabled` when running `func deploy`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. approved 🤖 PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1071 (fe91bdf) into main (91e80c0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1071      +/-   ##
==========================================
- Coverage   47.54%   47.51%   -0.04%     
==========================================
  Files          59       59              
  Lines        8017     8017              
==========================================
- Hits         3812     3809       -3     
- Misses       3829     3831       +2     
- Partials      376      377       +1     
Impacted Files Coverage Δ
cmd/deploy.go 55.15% <100.00%> (ø)
s2i/builder.go 65.44% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e80c0...fe91bdf. Read the comment docs.

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm !

@knative-prow knative-prow bot added the lgtm 🤖 PR is ready to be merged. label Jun 16, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

func deploy should only prompt build questions if build argument is set to true

2 participants