Skip to content

Preserve func.yaml for Quarkus BP build#1092

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:preserve-func-yaml-quarkus-build
Jun 30, 2022
Merged

Preserve func.yaml for Quarkus BP build#1092
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:preserve-func-yaml-quarkus-build

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jun 30, 2022

Changes

  • 🐛 Fix On Cluster Build issues with Quarkus buildpack build not preserving func.yaml.
bugfix: on cluster build issues with Quarkus buildpack build not preserving `func.yaml`

@knative-prow
Copy link

knative-prow bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek matejvasek requested a review from jrangelramos June 30, 2022 13:30
@knative-prow knative-prow bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. approved 🤖 PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2022
@matejvasek matejvasek requested a review from zroubalik June 30, 2022 13:30
@matejvasek
Copy link
Contributor Author

matejvasek commented Jun 30, 2022

Beware I did not tested this code with Tekton Pipeline.

I just tested that an image build locally does contain the func.yaml file, based on that I believe this should fix in cluster build for Quarkus.

@codecov
Copy link

codecov bot commented Jun 30, 2022 •
edited
Loading

Codecov Report

Merging #1092 (1d11a86) into main (04b32d1) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   45.01%   44.98%   -0.04%     
==========================================
  Files          64       64              
  Lines        8452     8452              
==========================================
- Hits         3805     3802       -3     
- Misses       4266     4268       +2     
- Partials      381      382       +1
Impacted Files Coverage Δ
pipelines/tekton/validate.go 84.61% <100.00%> (ø)
s2i/builder.go 63.07% <0.00%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b32d1...1d11a86. Read the comment docs.

@matejvasek matejvasek requested review from lance and lkingland June 30, 2022 13:38
lance
lance reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for others/tests
Funny how sometimes it's only a couple of simple changes that are needed! 👍

@knative-prow knative-prow bot added the do-not-merge/hold 🤖 PR should not merge because someone has issued a /hold command. label Jun 30, 2022
@knative-prow knative-prow bot added the lgtm 🤖 PR is ready to be merged. label Jun 30, 2022
@matejvasek matejvasek force-pushed the preserve-func-yaml-quarkus-build branch from 4df1a92 to 950e2f2 Compare June 30, 2022 14:14
@knative-prow knative-prow bot removed the lgtm 🤖 PR is ready to be merged. label Jun 30, 2022
@matejvasek matejvasek force-pushed the preserve-func-yaml-quarkus-build branch from 950e2f2 to be8bf2e Compare June 30, 2022 14:16
@knative-prow knative-prow bot added size/S 🤖 PR changes 10-29 lines, ignoring generated files. and removed size/XS 🤖 PR changes 0-9 lines, ignoring generated files. labels Jun 30, 2022
@matejvasek
Copy link
Contributor Author

matejvasek commented Jun 30, 2022

@lance I also updated validation, please re-lgtm.

@matejvasek
Preserve func.yaml for Quarkus BP build
1d11a86 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek matejvasek force-pushed the preserve-func-yaml-quarkus-build branch from be8bf2e to 1d11a86 Compare June 30, 2022 14:38
lance
lance reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm with one nit

@jrangelramos
Copy link
Contributor

jrangelramos commented Jun 30, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm 🤖 PR is ready to be merged. label Jun 30, 2022
@matejvasek
Copy link
Contributor Author

matejvasek commented Jun 30, 2022

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold 🤖 PR should not merge because someone has issued a /hold command. label Jun 30, 2022
@knative-prow knative-prow bot merged commit d4f96bb into knative:main Jun 30, 2022
gauron99 pushed a commit to gauron99/func that referenced this pull request May 6, 2025
@serverless-qe
Update dependabot configurations (knative#1092)
6981324 
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@zroubalik zroubalik Awaiting requested review from zroubalik

@lkingland lkingland Awaiting requested review from lkingland

1 more reviewer

@lance lance lance left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lance lance

@jrangelramos jrangelramos

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matejvasek @jrangelramos @lance