Skip to content

Comments

bump: update codecov to v5 in workflows#2705

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:update-covecov-action
Feb 19, 2025
Merged

bump: update codecov to v5 in workflows#2705
knative-prow[bot] merged 1 commit intoknative:mainfrom
gauron99:update-covecov-action

Conversation

@gauron99
Copy link
Contributor

bump codecov to v5 in workflows

@knative-prow knative-prow bot requested review from jrangelramos and rhuss February 19, 2025 12:31
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2025
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@knative-prow
Copy link

knative-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.31%. Comparing base (88afd64) to head (5547753).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
+ Coverage   64.03%   65.31%   +1.28%     
==========================================
  Files         131      131              
  Lines       15591    15591              
==========================================
+ Hits         9984    10184     +200     
+ Misses       4655     4418     -237     
- Partials      952      989      +37     
Flag Coverage Δ
e2e-test 35.86% <ø> (+0.02%) ⬆️
e2e-test-oncluster 34.21% <ø> (+1.39%) ⬆️
e2e-test-oncluster-runtime 28.57% <ø> (?)
e2e-test-runtime-go 26.47% <ø> (?)
e2e-test-runtime-node 25.88% <ø> (?)
e2e-test-runtime-python 25.88% <ø> (?)
e2e-test-runtime-quarkus 26.03% <ø> (?)
e2e-test-runtime-rust 24.96% <ø> (?)
e2e-test-runtime-springboot 25.02% <ø> (?)
e2e-test-runtime-typescript 25.98% <ø> (?)
integration-tests 51.95% <ø> (+2.29%) ⬆️
unit-tests 50.90% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

Why the hell is codecov/project duplicated? And one is passing while the other is failing?

@matejvasek
Copy link
Contributor

/retest codecov/project

@knative-prow
Copy link

knative-prow bot commented Feb 19, 2025

@matejvasek: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test unit-tests

Use /test all to run all jobs.

Details

In response to this:

/retest codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@gauron99 gauron99 force-pushed the update-covecov-action branch from e7e1f1c to 5547753 Compare February 19, 2025 13:38
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@matejvasek
Copy link
Contributor

/test unit-tests

@gauron99
Copy link
Contributor Author

the unit tests are flaky today, failing locally as well, strange

@knative-prow knative-prow bot merged commit 104e90c into knative:main Feb 19, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants