-
Notifications
You must be signed in to change notification settings - Fork 164
Add raw deployment deployer #3075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c0a7e4d to
f0fa249
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3075 +/- ##
==========================================
- Coverage 58.31% 52.54% -5.77%
==========================================
Files 134 146 +12
Lines 17377 14801 -2576
==========================================
- Hits 10133 7777 -2356
+ Misses 6303 6051 -252
- Partials 941 973 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8e688bf to
d37451e
Compare
988a5c4 to
cb1d6dc
Compare
|
Rebased after #3100 was in |
eb5f35d to
baf0d1a
Compare
This allows to get the logs of the deployment too
baf0d1a to
74b9af5
Compare
e3ec44a to
4c1b43b
Compare
…re in WaitForDeploymentsAvailable functions
4c1b43b to
5d1d3da
Compare
|
/cc @lkingland @gauron99 @matzew |
Changes
pkg:pkg/deployer: This has the two deployer options (as sub packages). That way it should be "easier" to add additional deployers (e.g. for wasm...) laterMultiDescriber,MultiRemoverandMultiListerwhich are the defaults in the client setup now. Those check the existing source (service for thefunction.knative.dev/deploy-typeannotation) and then delegate the action (Describe, Remove or List) to the according implementation./kind enhancement
Fixes: #2804
Release Note