Skip to content

Conversation

@lkingland
Copy link
Member

The default deploy image should be the last one built if available.

@knative-prow knative-prow bot requested review from dsimansk and nainaz October 15, 2025 08:09
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.15%. Comparing base (431d24e) to head (6ef9e75).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/knative/deployer.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3100      +/-   ##
==========================================
+ Coverage   58.41%   59.15%   +0.73%     
==========================================
  Files         134      134              
  Lines       17263    17266       +3     
==========================================
+ Hits        10085    10213     +128     
+ Misses       6246     6092     -154     
- Partials      932      961      +29     
Flag Coverage Δ
e2e-tests 40.35% <0.00%> (+1.33%) ⬆️
integration-tests 53.89% <0.00%> (+1.63%) ⬆️
unit-tests 46.24% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link
Contributor

/retest-required

@gauron99
Copy link
Contributor

gauron99 commented Oct 16, 2025

this unit test fail seems to be caused by go bump to 1.25; Im fixing this elsewhere

@gauron99
Copy link
Contributor

/retest-required

@knative-prow knative-prow bot merged commit 8eaeb5a into knative:main Oct 16, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants