refactor typed-error-describe#3111
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
+ Coverage 58.41% 59.17% +0.76%
==========================================
Files 134 134
Lines 17263 17315 +52
==========================================
+ Hits 10085 10247 +162
+ Misses 6246 6105 -141
- Partials 932 963 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99, is the first failing test case failure related to my PR? |
@intojhanurag I think it was a flake, I re-ran the test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, intojhanurag The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replaced the string-based error with a typed error
ErrNameAndPathConflict.