Skip to content

refactor typed-error-describe#3111

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
intojhanurag:fix/typed-error-describe
Oct 17, 2025
Merged

refactor typed-error-describe#3111
knative-prow[bot] merged 1 commit intoknative:mainfrom
intojhanurag:fix/typed-error-describe

Conversation

@intojhanurag
Copy link
Copy Markdown
Member

Replaced the string-based error with a typed error ErrNameAndPathConflict.

@knative-prow knative-prow Bot requested review from jrangelramos and nainaz October 17, 2025 05:48
@knative-prow knative-prow Bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label Oct 17, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 17, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label Oct 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.17%. Comparing base (86062c2) to head (8496e29).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   58.41%   59.17%   +0.76%     
==========================================
  Files         134      134              
  Lines       17263    17315      +52     
==========================================
+ Hits        10085    10247     +162     
+ Misses       6246     6105     -141     
- Partials      932      963      +31     
Flag Coverage Δ
e2e-tests 40.30% <0.00%> (+1.28%) ⬆️
integration-tests 53.91% <100.00%> (+1.65%) ⬆️
unit-tests 46.27% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Copy Markdown
Member Author

Hey @gauron99, is the first failing test case failure related to my PR?

@gauron99
Copy link
Copy Markdown
Contributor

Hey @gauron99, is the first failing test case failure related to my PR?

@intojhanurag I think it was a flake, I re-ran the test

Copy link
Copy Markdown
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Oct 17, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, intojhanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@knative-prow knative-prow Bot merged commit bfd65ae into knative:main Oct 17, 2025
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants