Skip to content

Add ESLint support for Node.js templates #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
intojhanurag wants to merge 1 commit into from
Closed

Add ESLint support for Node.js templates #3134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ check-embedded-fs: ## Check the embedded templates FS

# TODO: add linters for other templates
.PHONY: check-templates
check-templates: check-go check-rust ## Run template source code checks
check-templates: check-go check-rust check-node ## Run template source code checks

.PHONY: check-go
check-go: ## Check Go templates' source
Expand All @@ -153,6 +153,11 @@ check-rust: ## Check Rust templates' source
cd templates/rust/cloudevents && cargo clippy && cargo clean
cd templates/rust/http && cargo clippy && cargo clean

.PHONY: check-node
check-node: ## Check Node templates' source
cd templates/node/cloudevents && npm ci && npm run lint
cd templates/node/http && npm ci && npm run lint

.PHONY: test-templates
test-templates: test-go test-node test-python test-quarkus test-springboot test-rust test-typescript ## Run all template tests

Expand Down
8 changes: 8 additions & 0 deletions templates/node/cloudevents/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import js from "@eslint/js";
import globals from "globals";
import { defineConfig } from "eslint/config";

export default defineConfig([
{ files: ["**/*.{js,mjs,cjs}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },
{ files: ["**/*.js"], languageOptions: { sourceType: "commonjs" } },
]);
Loading
Loading