Skip to content

Conversation

@intojhanurag
Copy link
Contributor

Changes

  • Lists existing webhooks for a project before creating a new one.
  • Returns early if a webhook with the same URL already exists.
  • Ensures that only one webhook per URL is created, preventing duplicate notifications.

@knative-prow
Copy link

knative-prow bot commented Oct 24, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.11%. Comparing base (39c321d) to head (5299320).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/git/gitlab/gitlab.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3145      +/-   ##
==========================================
+ Coverage   59.39%   60.11%   +0.71%     
==========================================
  Files         134      134              
  Lines       13495    13508      +13     
==========================================
+ Hits         8016     8120     +104     
+ Misses       4538     4416     -122     
- Partials      941      972      +31     
Flag Coverage Δ
e2e-tests 41.66% <0.00%> (+1.42%) ⬆️
integration-tests 54.66% <0.00%> (+1.66%) ⬆️
unit-tests 46.69% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Contributor Author

Hey @gauron99 , This one is ready for review.

@intojhanurag intojhanurag force-pushed the fix/gitlab-webhook-duplicate-check branch from 4076fc6 to 05f0278 Compare October 24, 2025 08:21
@gauron99
Copy link
Contributor

lets add a message like "webhook already exists" and point to url or something please for more info

@gauron99
Copy link
Contributor

thanks for the contribution!

@gauron99
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2025
@intojhanurag
Copy link
Contributor Author

lets add a message like "webhook already exists" and point to url or something please for more info

Hey @gauron99 , Now, Is it good to go ?

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, intojhanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2025
@knative-prow knative-prow bot merged commit 0bc91f3 into knative:main Nov 2, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants