-
Notifications
You must be signed in to change notification settings - Fork 165
Prevent duplicate GitLab webhooks by checking existing hooks #3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent duplicate GitLab webhooks by checking existing hooks #3145
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
==========================================
+ Coverage 59.39% 60.11% +0.71%
==========================================
Files 134 134
Lines 13495 13508 +13
==========================================
+ Hits 8016 8120 +104
+ Misses 4538 4416 -122
- Partials 941 972 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , This one is ready for review. |
4076fc6 to
05f0278
Compare
|
lets add a message like "webhook already exists" and point to url or something please for more info |
|
thanks for the contribution! |
|
/ok-to-test |
Hey @gauron99 , Now, Is it good to go ? |
gauron99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, intojhanurag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes