Skip to content

Prevent duplicate GitLab webhooks by checking existing hooks #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2025
Merged

Prevent duplicate GitLab webhooks by checking existing hooks #3145

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb994d8
Check for existing GitLab webhook before creating to avoid duplicates
intojhanurag Oct 24, 2025
05f0278
path issue
intojhanurag Oct 24, 2025
5299320
gitlab hooks
intojhanurag Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions pkg/git/gitlab/gitlab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,28 @@ func (c Client) CreateWebHook(ctx context.Context, repoOwner, repoName, payloadU
if err != nil {
return fmt.Errorf("cannot create GitLab client: %w", err)
}

projectPath := repoOwner + "/" + repoName

existingHooks, _, err := glabCli.Projects.ListProjectHooks(projectPath, nil)
if err != nil {
return fmt.Errorf("cannot list existing hooks: %w", err)
}
for _, hook := range existingHooks {
if hook.URL == payloadURL {
fmt.Printf("GitLab webhook already exists for project %s at URL: %s\n", projectPath, payloadURL)
return nil
}
}

webhook := &gitlab.AddProjectHookOptions{
EnableSSLVerification: &f,
PushEvents: &t,
Token: &webhookSecret,
URL: &payloadURL,
}
// TODO check if the WebHook already exists. GitLab doesn't name WebHooks so there is never 403.
_, _, err = glabCli.Projects.AddProjectHook(repoOwner+"/"+repoName, webhook)

_, _, err = glabCli.Projects.AddProjectHook(projectPath, webhook)
if err != nil {
return fmt.Errorf("cannot create gitlab webhook: %w", err)
}
Expand Down
Loading