refactor(mcp): make Name, Title, Version unexported and improved comment#3171
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
+ Coverage 62.85% 63.87% +1.02%
==========================================
Files 148 150 +2
Lines 13202 13210 +8
==========================================
+ Hits 8298 8438 +140
+ Misses 3941 3783 -158
- Partials 963 989 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , Can you take a look on it , if you have a moment ? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: intojhanurag, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR applies a reviewer suggestion left unimplemented in a previous merge.
Refactors Name, Title, and Version constants to unexported (name, title, version) as suggested for better encapsulation and to align with Go naming conventions and also clarify command execution comment.
Follow-up to: #3155