-
Notifications
You must be signed in to change notification settings - Fork 165
test(mcp): merge languages and templates tests into table-driven test #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test(mcp): merge languages and templates tests into table-driven test #3188
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3188 +/- ##
==========================================
+ Coverage 59.06% 59.39% +0.32%
==========================================
Files 162 162
Lines 14763 14763
==========================================
+ Hits 8720 8768 +48
+ Misses 5019 4943 -76
- Partials 1024 1052 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: intojhanurag, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Hey @lkingland , If any issue is on my side. lmk I will be happy to improve. |
Converts TestResource_Languages and TestResource_Templates into a single table-driven test to remove duplication and keep tests consistent.