Skip to content

test(mcp): merge languages and templates tests into table-driven test #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(mcp): merge languages and templates tests into table-driven test #3188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 67 additions & 91 deletions pkg/mcp/resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,106 +84,82 @@ func TestResource_FunctionState(t *testing.T) {
}
}

func TestResource_Languages(t *testing.T) {
expectedOutput := `go
func TestResource_Listings(t *testing.T) {
cases := []struct {
name string
uri string
subcommand string
expectedOutput string
}{
{
name: "languages",
uri: "func://languages",
subcommand: "languages",
expectedOutput: `go
node
python
etc
`

executor := mock.NewExecutor()
executor.ExecuteFn = func(ctx context.Context, subcommand string, args ...string) ([]byte, error) {
if subcommand != "languages" {
t.Fatalf("expected subcommand 'languages', got %q", subcommand)
}
if len(args) != 0 {
t.Fatalf("expected no args, got %v", args)
}
return []byte(expectedOutput), nil
}

client, _, err := newTestPair(t, WithExecutor(executor))
if err != nil {
t.Fatal(err)
}

result, err := client.ReadResource(context.Background(), &mcp.ReadResourceParams{
URI: "func://languages",
})
if err != nil {
t.Fatal(err)
}

if len(result.Contents) != 1 {
t.Fatalf("expected 1 content, got %d", len(result.Contents))
}

content := result.Contents[0]
if content.URI != "func://languages" {
t.Fatalf("expected URI 'func://languages', got %q", content.URI)
}
if content.MIMEType != "text/plain" {
t.Fatalf("expected MIME type 'text/plain', got %q", content.MIMEType)
}
if content.Text != expectedOutput {
t.Fatalf("expected output:\n%s\ngot:\n%s", expectedOutput, content.Text)
}

if !executor.ExecuteInvoked {
t.Fatal("executor was not invoked")
}
}

func TestResource_Templates(t *testing.T) {
expectedOutput := `LANGUAGE TEMPLATE
`,
},
{
name: "templates",
uri: "func://templates",
subcommand: "templates",
expectedOutput: `LANGUAGE TEMPLATE
go cloudevents
go http
node cloudevents
node http
python cloudevents
python http
etc etc
`

executor := mock.NewExecutor()
executor.ExecuteFn = func(ctx context.Context, subcommand string, args ...string) ([]byte, error) {
if subcommand != "templates" {
t.Fatalf("expected subcommand 'templates', got %q", subcommand)
}
if len(args) != 0 {
t.Fatalf("expected no args, got %v", args)
}
return []byte(expectedOutput), nil
}

client, _, err := newTestPair(t, WithExecutor(executor))
if err != nil {
t.Fatal(err)
}

result, err := client.ReadResource(context.Background(), &mcp.ReadResourceParams{
URI: "func://templates",
})
if err != nil {
t.Fatal(err)
}

if len(result.Contents) != 1 {
t.Fatalf("expected 1 content, got %d", len(result.Contents))
}

content := result.Contents[0]
if content.URI != "func://templates" {
t.Fatalf("expected URI 'func://templates', got %q", content.URI)
}
if content.MIMEType != "text/plain" {
t.Fatalf("expected MIME type 'text/plain', got %q", content.MIMEType)
}
if content.Text != expectedOutput {
t.Fatalf("expected output:\n%s\ngot:\n%s", expectedOutput, content.Text)
}

if !executor.ExecuteInvoked {
t.Fatal("executor was not invoked")
`,
},
}

for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
executor := mock.NewExecutor()
executor.ExecuteFn = func(ctx context.Context, subcommand string, args ...string) ([]byte, error) {
if subcommand != tc.subcommand {
t.Fatalf("expected subcommand %q, got %q", tc.subcommand, subcommand)
}
if len(args) != 0 {
t.Fatalf("expected no args, got %v", args)
}
return []byte(tc.expectedOutput), nil
}

client, _, err := newTestPair(t, WithExecutor(executor))
if err != nil {
t.Fatal(err)
}

result, err := client.ReadResource(context.Background(), &mcp.ReadResourceParams{
URI: tc.uri,
})
if err != nil {
t.Fatal(err)
}

if len(result.Contents) != 1 {
t.Fatalf("expected 1 content, got %d", len(result.Contents))
}

content := result.Contents[0]
if content.URI != tc.uri {
t.Fatalf("expected URI %q, got %q", tc.uri, content.URI)
}
if content.MIMEType != "text/plain" {
t.Fatalf("expected MIME type 'text/plain', got %q", content.MIMEType)
}
if content.Text != tc.expectedOutput {
t.Fatalf("expected output:\n%s\ngot:\n%s", tc.expectedOutput, content.Text)
}

if !executor.ExecuteInvoked {
t.Fatal("executor was not invoked")
}
})
}
}
Loading