Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Jan 21, 2026

Changes

  • 🧹 For the raw deployer, add an OwnerReference on the service to the deployment to delegate the cleanup to the API server

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 21, 2026
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2026
@creydr
Copy link
Member Author

creydr commented Jan 21, 2026

/cc @gauron99 @lkingland

@knative-prow knative-prow bot requested review from gauron99 and lkingland January 21, 2026 09:17
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.56%. Comparing base (c2e4cf1) to head (9aeb356).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/k8s/deployer.go 46.66% 12 Missing and 4 partials ⚠️
pkg/k8s/remover.go 0.00% 2 Missing and 1 partial ⚠️
pkg/k8s/wait.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
+ Coverage   55.53%   55.56%   +0.03%     
==========================================
  Files         173      173              
  Lines       20005    20085      +80     
==========================================
+ Hits        11109    11161      +52     
- Misses       7780     7802      +22     
- Partials     1116     1122       +6     
Flag Coverage Δ
e2e 39.66% <0.00%> (-0.11%) ⬇️
e2e go 35.45% <0.00%> (-0.09%) ⬇️
e2e node 31.22% <0.00%> (-0.07%) ⬇️
e2e python 34.95% <0.00%> (-0.09%) ⬇️
e2e quarkus 31.35% <0.00%> (-0.07%) ⬇️
e2e rust 30.79% <0.00%> (-0.07%) ⬇️
e2e springboot 29.23% <0.00%> (-0.08%) ⬇️
e2e typescript 31.34% <0.00%> (-0.07%) ⬇️
integration 18.67% <58.82%> (+0.03%) ⬆️
unit macos-14 44.82% <0.00%> (+0.03%) ⬆️
unit macos-latest 44.82% <0.00%> (+0.03%) ⬆️
unit ubuntu-24.04-arm 44.91% <0.00%> (+0.02%) ⬆️
unit ubuntu-latest 45.71% <0.00%> (+0.03%) ⬆️
unit windows-latest 44.84% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for potential other reviews, unhold when you please

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2026
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026
@creydr
Copy link
Member Author

creydr commented Jan 21, 2026

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2026
@knative-prow knative-prow bot merged commit 5c1a09f into knative:main Jan 21, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants