-
Notifications
You must be signed in to change notification settings - Fork 176
Add OwnerReference on service to deployment to delegate cleanup to API server #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OwnerReference on service to deployment to delegate cleanup to API server #3377
Conversation
|
/cc @gauron99 @lkingland |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
+ Coverage 55.53% 55.56% +0.03%
==========================================
Files 173 173
Lines 20005 20085 +80
==========================================
+ Hits 11109 11161 +52
- Misses 7780 7802 +22
- Partials 1116 1122 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for potential other reviews, unhold when you please
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Changes
/kind cleanup