add middleware version as image label#3408
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3408 +/- ##
==========================================
+ Coverage 54.61% 54.65% +0.04%
==========================================
Files 173 173
Lines 19814 19826 +12
==========================================
+ Hits 10821 10836 +15
+ Misses 7861 7857 -4
- Partials 1132 1133 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b2e559f to
542458f
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gauron99 can we backport this fix to 1.21? |
|
/cherry-pick release-1.21 |
|
@gauron99: new pull request created: #3410 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add the middleware-version image label to function images built by S2I and Pack builders to preserve complete the implementation. OCI already implements this (only added unit test since we can inspect the actual blobs/files created)
func build --builder=s2i --pushDocker inspect..."middleware-version": "v0.21.3",PS:
some pack tests needed proper directory root because middleware fetch uses actual path detection for those templates (so it needs proper function root)
PSS: the s2i was added prior by Christoph but removed by me in the XXL scaffolding PR. Re-adding it here.
/kind enhancement
/fixes #3406