Skip to content

Update docs with RBAC for raw & keda remote deploys#3427

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
creydr:update-docs-for-remote-deploy
Feb 11, 2026
Merged

Update docs with RBAC for raw & keda remote deploys#3427
knative-prow[bot] merged 2 commits intoknative:mainfrom
creydr:update-docs-for-remote-deploy

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Feb 9, 2026

Updating the docs with the require roles & rolebindings to make the remote deployments with the raw & keda deployer work

@knative-prow knative-prow Bot added the size/M 🤖 PR changes 30-99 lines, ignoring generated files. label Feb 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.56%. Comparing base (f75c581) to head (94cea86).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3427      +/-   ##
==========================================
- Coverage   54.62%   54.56%   -0.07%     
==========================================
  Files         179      179              
  Lines       20228    20214      -14     
==========================================
- Hits        11049    11029      -20     
- Misses       8009     8013       +4     
- Partials     1170     1172       +2     
Flag Coverage Δ
e2e 38.54% <ø> (-0.03%) ⬇️
e2e go 32.72% <ø> (-0.03%) ⬇️
e2e node 28.62% <ø> (-0.03%) ⬇️
e2e python 32.23% <ø> (-0.01%) ⬇️
e2e quarkus 28.77% <ø> (-0.03%) ⬇️
e2e rust 28.17% <ø> (-0.05%) ⬇️
e2e springboot 26.64% <ø> (-0.04%) ⬇️
e2e typescript 28.73% <ø> (-0.03%) ⬇️
integration 17.57% <ø> (-0.04%) ⬇️
unit macos-14 42.25% <ø> (-0.03%) ⬇️
unit macos-latest 42.25% <ø> (-0.03%) ⬇️
unit ubuntu-24.04-arm 42.57% <ø> (-0.04%) ⬇️
unit ubuntu-latest 43.15% <ø> (-0.03%) ⬇️
unit windows-latest 42.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Copy Markdown
Contributor

If I understand correctly - on changing deployer this would require removing the old permissions to set new permissions. Should we also include a "one fits all" setup which could set all permissions for all deployers?
Or do you think its too permission-less this way ?

@creydr
Copy link
Copy Markdown
Member Author

creydr commented Feb 10, 2026

If I understand correctly - on changing deployer this would require removing the old permissions to set new permissions. Should we also include a "one fits all" setup which could set all permissions for all deployers? Or do you think its too permission-less this way ?

TBH: I was wondering the same, but somehow didn't follow up on this. Let me add a solution for all deployers too

@creydr
Copy link
Copy Markdown
Member Author

creydr commented Feb 10, 2026

/cc @gauron99

@knative-prow knative-prow Bot requested a review from gauron99 February 10, 2026 15:44
@gauron99
Copy link
Copy Markdown
Contributor

thanks! awesome
/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Feb 11, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Feb 11, 2026
@knative-prow knative-prow Bot merged commit 228c8eb into knative:main Feb 11, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/M 🤖 PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants