test: use t.Context() instead of context.Background()#3525
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Mar 25, 2026
Merged
test: use t.Context() instead of context.Background()#3525knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
Replace context.Background() and context.TODO() with the testing context t.Context() (available since Go 1.24) across all test files. This ties context lifecycle to the test lifecycle, providing automatic cancellation when tests end. Cleanup functions (t.Cleanup) retain context.Background() since t.Context() is cancelled before cleanup runs. Unused "context" imports are removed where applicable. Signed-off-by: Matej Vašek <matejvasek@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
knative-prow
Bot
added
the
approved
knative-prow
Bot
added
the
size/L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3525 +/- ##
==========================================
- Coverage 55.55% 55.54% -0.01%
==========================================
Files 180 180
Lines 20465 20465
==========================================
- Hits 11370 11368 -2
- Misses 7896 7898 +2
Partials 1199 1199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
Contributor
|
ehm what? |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.