ci: add workflow_dispatch to scheduled update workflows#3552
Conversation
Fixes knative#3548 update-python-platform already had workflow_dispatch for manual triggering, but the remaining scheduled update workflows did not. Without it there is no way to re-run a workflow outside its schedule without editing the cron expression.
knative-prow
Bot
added
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Adds manual triggering support (workflow_dispatch) to scheduled update workflows so they can be run ad-hoc for debugging/testing without modifying cron schedules.
Changes:
- Added
workflow_dispatchtrigger toupdate-builderworkflow. - Added
workflow_dispatchtrigger toupdate-quarkus-platform,update-springboot-platform, andupdate-ca-bundleworkflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/update-builder.yaml | Allows manually triggering the builder image update workflow in addition to its hourly schedule. |
| .github/workflows/update-quarkus-platform.yaml | Enables manual runs for the Quarkus platform update workflow. |
| .github/workflows/update-springboot-platform.yaml | Enables manual runs for the Spring Boot platform update workflow. |
| .github/workflows/update-ca-bundle.yaml | Enables manual runs for the CA bundle update workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3552 +/- ##
==========================================
+ Coverage 55.52% 56.23% +0.71%
==========================================
Files 180 180
Lines 20465 20465
==========================================
+ Hits 11363 11509 +146
+ Misses 7902 7756 -146
Partials 1200 1200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
knative-prow
Bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
Closes #3548
update-python-platformalready hadworkflow_dispatchfor manual triggering, but the remaining scheduled update workflows did not. Without it there is no way to re-run a workflow outside its schedule without editing the cron expression, making ad-hoc testing and debugging painful.Affected workflows:
update-builder,update-quarkus-platform,update-springboot-platform,update-ca-bundle.