Skip to content

ci: replace ad-hoc rm -rf with free-disk-space action in test-podman-next#3558

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/replace-rm-rf-with-free-disk-space-podman-next-clean
Apr 1, 2026
Merged

ci: replace ad-hoc rm -rf with free-disk-space action in test-podman-next#3558
knative-prow[bot] merged 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/replace-rm-rf-with-free-disk-space-podman-next-clean

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Fixes #3554

Summary

  • Replaces three manual sudo rm -rf lines in test-podman-next.yaml with the standardized endersonmenezes/free-disk-space@v3 action
  • The action also removes swap (remove_swap: true), which the manual approach missed
  • Uses rmz for faster removal, consistent with all other long-running CI jobs

Test plan

  • Verify the workflow runs successfully with the new action
  • Confirm disk space is freed before the podman-next test step

The three manual sudo rm -rf lines are inconsistent with every other
long-running CI job, which all use endersonmenezes/free-disk-space@v3.
The action also removes swap (missed by the manual approach) and is
easier to audit.
Copilot AI review requested due to automatic review settings April 1, 2026 08:23
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos April 1, 2026 08:23
@knative-prow knative-prow Bot added size/S 🤖 PR changes 10-29 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Apr 1, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 1, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the scheduled Podman “next” CI workflow to use the repository-standard disk cleanup approach, aligning it with other long-running workflows and addressing #3554.

Changes:

  • Replaces ad-hoc sudo rm -rf cleanup with endersonmenezes/free-disk-space@v3.
  • Enables swap removal (remove_swap: true) and standardizes on rm_cmd: "rmz" for faster cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.22%. Comparing base (e92b074) to head (c35d875).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
+ Coverage   55.52%   56.22%   +0.70%     
==========================================
  Files         180      180              
  Lines       20465    20465              
==========================================
+ Hits        11363    11507     +144     
+ Misses       7902     7757     -145     
- Partials     1200     1201       +1     
Flag Coverage Δ
e2e 36.12% <ø> (-4.06%) ⬇️
e2e go 32.55% <ø> (ø)
e2e node 28.36% <ø> (ø)
e2e python 32.91% <ø> (ø)
e2e quarkus 28.50% <ø> (+0.02%) ⬆️
e2e rust 27.92% <ø> (ø)
e2e springboot 26.38% <ø> (+0.02%) ⬆️
e2e typescript 28.47% <ø> (ø)
e2e-config-ci 18.14% <ø> (ø)
integration 17.40% <ø> (+<0.01%) ⬆️
unit macos-14 43.37% <ø> (ø)
unit macos-latest 43.37% <ø> (ø)
unit ubuntu-24.04-arm 43.57% <ø> (ø)
unit ubuntu-latest 44.25% <ø> (ø)
unit windows-latest 43.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Apr 1, 2026

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels Apr 1, 2026
@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Apr 1, 2026

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Apr 1, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitsinghsisodya, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@knative-prow knative-prow Bot merged commit 9835303 into knative:main Apr 1, 2026
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: test-podman-next.yaml uses ad-hoc rm -rf instead of free-disk-space action

3 participants