ci: replace ad-hoc rm -rf with free-disk-space action in test-podman-next#3558
Conversation
The three manual sudo rm -rf lines are inconsistent with every other long-running CI job, which all use endersonmenezes/free-disk-space@v3. The action also removes swap (missed by the manual approach) and is easier to audit.
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Updates the scheduled Podman “next” CI workflow to use the repository-standard disk cleanup approach, aligning it with other long-running workflows and addressing #3554.
Changes:
- Replaces ad-hoc
sudo rm -rfcleanup withendersonmenezes/free-disk-space@v3. - Enables swap removal (
remove_swap: true) and standardizes onrm_cmd: "rmz"for faster cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
==========================================
+ Coverage 55.52% 56.22% +0.70%
==========================================
Files 180 180
Lines 20465 20465
==========================================
+ Hits 11363 11507 +144
+ Misses 7902 7757 -145
- Partials 1200 1201 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #3554
Summary
sudo rm -rflines intest-podman-next.yamlwith the standardizedendersonmenezes/free-disk-space@v3actionremove_swap: true), which the manual approach missedrmzfor faster removal, consistent with all other long-running CI jobsTest plan