[release-1.20] Remember `--registry-insecure` setting on recurring runs + backport fixes by creydr · Pull Request #3588 · knative/func

creydr · 2026-04-07T15:03:27Z

Manual backport of #3574

also adding

python template cloudevents package pin to <2 (introduces breaking changes)
update-deps.sh backport for conditional run of knative-components bump

…ns (knative#3574) * Pass --registry-insecure flag to Tekton pipeline tlsVerify parameter (knative#3484) When --registry-insecure is used, set tlsVerify=false in the Tekton pipeline to allow buildah to push to registries with self-signed certs. * Remember `--registry-insecure` setting on recurring runs (knative#3490) * Revert "Pass --registry-insecure flag to Tekton pipeline tlsVerify parameter (knative#3484)" This reverts commit da21fa2. * Remember `--registry-insecure` setting on recurring runs * Run `make schema-generate` * Simplify parsing * Extend description of flag, that values are persited * Add warning, when registry changed but insecure-registry is still set to true * Fix typo * Rerun update-codegen * Cleanup test names * Add unit test for WarnRegistryInsecureChange * Run schema-generate * Update pkg/functions/client.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/functions/client.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/config/config.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Update pkg/config/config.go Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Fix format issues (goimport and gofmt) * Refactor registry-insecure unit test to make it available for the Deploy tests too * Refactor GlobalConfig.WarnRegistryInsecureChange() method to function in cmd package --------- Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> * Ran `./hack/update-codegen.sh` --------- Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>

gauron99 · 2026-04-07T16:21:38Z

Sorry, this is missing (most likely) a cloudevents python lib issue. There was a new cloudevents version release which has some breaking changes. You need to go into the python cloudevents template and pin the version to <2 (major) because we did not have it pinned at all.

gauron99 · 2026-04-07T16:22:19Z

for reference #3524

creydr · 2026-04-07T19:39:21Z

Sorry, this is missing (most likely) a cloudevents python lib issue. There was a new cloudevents version release which has some breaking changes. You need to go into the python cloudevents template and pin the version to <2 (major) because we did not have it pinned at all.

Ah ok. Thanks for the hint. Updated it 🤞

codecov · 2026-04-07T19:48:57Z

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.20@7052943). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/pipelines/tekton/templates.go	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##             release-1.20    #3588   +/-   ##
===============================================
  Coverage                ?   60.20%           
===============================================
  Files                   ?      134           
  Lines                   ?    13533           
  Branches                ?        0           
===============================================
  Hits                    ?     8147           
  Misses                  ?     4415           
  Partials                ?      971

Flag	Coverage Δ
e2e-tests	`41.61% <60.86%> (?)`
integration-tests	`54.78% <95.65%> (?)`
unit-tests	`46.84% <91.30%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

creydr · 2026-04-08T08:01:53Z

kubernetes version \"1.32.0\" is not compatible, need at least \"1.33.0-0\" (this can be overridden with the env var \"KUBERNETES_MIN_VERSION\")

This is because Knative components were updated by update-codegen.sh to 1.22 in aaad012

creydr · 2026-04-09T09:31:55Z

Closing as discussed

The test was creating a broken Procfile instead of a working main.go, causing the pipeline build to fail and the test to timeout.

This reverts commit 3f39a10.

creydr · 2026-04-13T20:27:17Z

/cc @matejvasek @gauron99

matejvasek · 2026-04-13T22:41:31Z

/approve
/lgtm

knative-prow · 2026-04-13T22:41:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

creydr and others added 2 commits April 7, 2026 16:58

Run update-codegen.sh

aaad012

knative-prow bot requested review from dsimansk and jrangelramos April 7, 2026 15:03

knative-prow bot added the size/XL 🤖 PR changes 500-999 lines, ignoring generated files. label Apr 7, 2026

Fix linter issues

ad643d1

Pin cloudevents to 1.x

3b134b8

creydr and others added 2 commits April 8, 2026 10:10

Use component-versions from 1.20

e9db273

smarter component updates (knative#3290)

b0c952f

gauron99 changed the title ~~[release-1.20] Remember --registry-insecure setting on recurring runs~~ [release-1.20] Remember --registry-insecure setting on recurring runs + backport fixes Apr 8, 2026

creydr closed this Apr 9, 2026

creydr reopened this Apr 13, 2026

knative-prow bot added size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. and removed size/XL 🤖 PR changes 500-999 lines, ignoring generated files. labels Apr 13, 2026

creydr force-pushed the cp-remember-registry-insecure-flag-1.20 branch 2 times, most recently from 38b2dee to b610705 Compare April 13, 2026 17:52

knative-prow bot added size/XL 🤖 PR changes 500-999 lines, ignoring generated files. and removed size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. labels Apr 13, 2026

creydr force-pushed the cp-remember-registry-insecure-flag-1.20 branch from b610705 to 5feb609 Compare April 13, 2026 18:02

knative-prow bot added size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. and removed size/XL 🤖 PR changes 500-999 lines, ignoring generated files. labels Apr 13, 2026

creydr force-pushed the cp-remember-registry-insecure-flag-1.20 branch from 5feb609 to 56d9970 Compare April 13, 2026 18:09

knative-prow bot added size/XL 🤖 PR changes 500-999 lines, ignoring generated files. and removed size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. labels Apr 13, 2026

creydr force-pushed the cp-remember-registry-insecure-flag-1.20 branch from 56d9970 to e625281 Compare April 13, 2026 18:17

Replace tekton hub with direct bundle references

426dd5d

creydr force-pushed the cp-remember-registry-insecure-flag-1.20 branch from e625281 to 426dd5d Compare April 13, 2026 18:22

creydr added 3 commits April 13, 2026 21:06

Fix TestGitlab by restoring valid Go application code

3f39a10

The test was creating a broken Procfile instead of a working main.go, causing the pipeline build to fail and the test to timeout.

Revert "Fix TestGitlab by restoring valid Go application code"

336cbdb

This reverts commit 3f39a10.

Replace tekton hub with direct bundle references (2)

63fa2d8

knative-prow bot requested review from gauron99 and matejvasek April 13, 2026 20:27

knative-prow bot assigned matejvasek Apr 13, 2026

knative-prow bot added the lgtm 🤖 PR is ready to be merged. label Apr 13, 2026

knative-prow bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Apr 13, 2026

knative-prow bot merged commit d4f2a40 into knative:release-1.20 Apr 14, 2026
52 of 57 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-1.20] Remember `--registry-insecure` setting on recurring runs + backport fixes#3588

[release-1.20] Remember `--registry-insecure` setting on recurring runs + backport fixes#3588
knative-prow[bot] merged 10 commits intoknative:release-1.20from
creydr:cp-remember-registry-insecure-flag-1.20

creydr commented Apr 7, 2026 •

edited by gauron99

Loading

Uh oh!

gauron99 commented Apr 7, 2026

Uh oh!

gauron99 commented Apr 7, 2026

Uh oh!

creydr commented Apr 7, 2026

Uh oh!

codecov bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

creydr commented Apr 8, 2026

Uh oh!

creydr commented Apr 9, 2026

Uh oh!

creydr commented Apr 13, 2026

Uh oh!

matejvasek commented Apr 13, 2026

Uh oh!

knative-prow bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

creydr commented Apr 7, 2026 • edited by gauron99 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gauron99 commented Apr 7, 2026

Uh oh!

gauron99 commented Apr 7, 2026

Uh oh!

creydr commented Apr 7, 2026

Uh oh!

codecov bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

creydr commented Apr 8, 2026

Uh oh!

creydr commented Apr 9, 2026

Uh oh!

creydr commented Apr 13, 2026

Uh oh!

matejvasek commented Apr 13, 2026

Uh oh!

knative-prow bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

creydr commented Apr 7, 2026 •

edited by gauron99

Loading

codecov bot commented Apr 7, 2026 •

edited

Loading