Use correct describer in pipelines provider#3600
Use correct describer in pipelines provider#3600knative-prow[bot] merged 4 commits intoknative:mainfrom
Conversation
knative-prow
Bot
added
the
size/M
|
/cc @gauron99 @matejvasek |
| Subscriptions []Subscription `json:"subscriptions" yaml:"subscriptions"` | ||
| Labels map[string]string `json:"labels" yaml:"labels" xml:"-"` | ||
| Middleware Middleware `json:"middleware,omitempty" yaml:"middleware,omitempty"` | ||
| Generation int64 `json:"generation,omitempty" yaml:"generation,omitempty"` |
There was a problem hiding this comment.
This is simply added, so we can say if some operations were an update or a create. See for example here:
func/pkg/pipelines/tekton/pipelines_provider.go
Lines 256 to 260 in 9592280
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3600 +/- ##
==========================================
+ Coverage 56.24% 56.30% +0.05%
==========================================
Files 180 180
Lines 20479 20512 +33
==========================================
+ Hits 11519 11549 +30
- Misses 7759 7761 +2
- Partials 1201 1202 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
|
Looks good but I am not sure if this would be all tested. Maybe modify |
knative-prow
Bot
added
size/L
creydr
force-pushed
the
use-correct-describer-in-pipelines-provider
branch
from
3fda878 to
f1d0438
Compare
The pipeline integration test was failing for raw and keda deployers because their services are only reachable via cluster-internal DNS (*.default.svc). The test used a plain http.Get which can't resolve these names from the runner. Use an in-cluster dialer (socat pod) for raw/keda, matching the pattern already used in deployer integration tests. Signed-off-by: Matej Vašek <matejvasek@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
|
/lgtm |
2 participants
Currently the pipelines provider tries to get the function information from the Knative Service. As we have additional deploy methods (raw + keda), this does not work anymore in all cases.
This PR addresses it and gets the deployments information correctly based on the deployer.