warn on extraneous keys used in func.yaml#3611
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Apr 16, 2026
Merged
warn on extraneous keys used in func.yaml#3611knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
knative-prow
Bot
added
the
do-not-merge/work-in-progress
knative-prow
Bot
added
approved
knative-prow
Bot
added
the
size/S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3611 +/- ##
==========================================
+ Coverage 56.27% 56.30% +0.03%
==========================================
Files 180 180
Lines 20522 20549 +27
==========================================
+ Hits 11548 11571 +23
- Misses 7773 7777 +4
Partials 1201 1201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
force-pushed
the
push-kxrnrqtrmwxs
branch
from
ddf6369 to
466cbd5
Compare
gauron99
requested review from
lkingland and
matejvasek
and removed request for
dsimansk and
jrangelramos
twoGiants
suggested changes
Apr 16, 2026
Contributor
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Looks good! Just add a few test cases covering the new conditional logic. Thank you 😸 👍
gauron99
force-pushed
the
push-kxrnrqtrmwxs
branch
from
466cbd5 to
df47c5f
Compare
knative-prow
Bot
added
size/L
gauron99
force-pushed
the
push-kxrnrqtrmwxs
branch
from
df47c5f to
5a0d73b
Compare
twoGiants
approved these changes
Apr 16, 2026
Contributor
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the tests.
I have just a minor nit => optional.
/approve
/lgtm
/hold for others
Comment on lines
+26
to
+35
| if f.Root != "" { | ||
| if bb, readErr := os.ReadFile(filepath.Join(f.Root, FunctionFile)); readErr == nil { | ||
| unknownFieldsOnce.Do(func() { | ||
| var strict Function | ||
| if strictErr := yaml.UnmarshalStrict(bb, &strict); strictErr != nil { | ||
| fmt.Fprintf(os.Stderr, "Warning (unknown fields will be ignored):\n %v\n.\n", formatUnmarshalError(strictErr)) | ||
| } | ||
| }) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit: use early return
Suggested change
| if f.Root != "" { | |
| if bb, readErr := os.ReadFile(filepath.Join(f.Root, FunctionFile)); readErr == nil { | |
| unknownFieldsOnce.Do(func() { | |
| var strict Function | |
| if strictErr := yaml.UnmarshalStrict(bb, &strict); strictErr != nil { | |
| fmt.Fprintf(os.Stderr, "Warning (unknown fields will be ignored):\n %v\n.\n", formatUnmarshalError(strictErr)) | |
| } | |
| }) | |
| } | |
| } | |
| if f.Root == "" { | |
| return f, nil | |
| } | |
| if bb, readErr := os.ReadFile(filepath.Join(f.Root, FunctionFile)); readErr == nil { | |
| unknownFieldsOnce.Do(func() { | |
| var strict Function | |
| if strictErr := yaml.UnmarshalStrict(bb, &strict); strictErr != nil { | |
| fmt.Fprintf(os.Stderr, "Warning (unknown fields will be ignored):\n %v\n.\n", formatUnmarshalError(strictErr)) | |
| } | |
| }) | |
| } |
knative-prow
Bot
added
do-not-merge/hold
matejvasek
reviewed
Apr 16, 2026
| // Migrate applies any necessary migrations, returning a new migrated | ||
| // version of the function. It is the caller's responsibility to | ||
| // .Write() the function to persist to disk. | ||
| // .Write() the function to persist to disk. Aditionaly it will warn on |
Contributor
There was a problem hiding this comment.
typo: Aditionaly => Additionally
gauron99
force-pushed
the
push-kxrnrqtrmwxs
branch
from
5a0d73b to
b2d0a34
Compare
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/unhold |
knative-prow
Bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding a warning for extraneous keys
when we have the latest (migrated) spec present, we do a strict Unmarshal (which errors on extraneous keys) and we print a warning like above.
Note that Im adding the "once" because NewFunction is actually called few times throughout a lets say "func deploy" call.