Remove legacy build directives#3623
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Apr 21, 2026
Merged
Conversation
knative-prow
Bot
added
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3623 +/- ##
==========================================
+ Coverage 55.61% 56.31% +0.70%
==========================================
Files 180 180
Lines 20549 20549
==========================================
+ Hits 11429 11573 +144
+ Misses 7960 7776 -184
- Partials 1160 1200 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The // +build syntax was retained only for compatibility with Go < 1.17. This module targets Go 1.25, so the parallel directive adds no value and just clutters the top of every tagged file; //go:build is the canonical form since Go 1.17 and remains in place. Applied to all 41 non-vendored files that carried the paired directive.
lkingland
force-pushed
the
push-ymuppxoyltxs
branch
from
88c1349 to
be9b289
Compare
lkingland
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
// +buildsyntax is only for compatibility with Go < 1.17. We now require Go 1.25.