Skip to content

Add function ready status in describe output#3627

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
creydr:add-function-status-in-describe-output
Apr 21, 2026
Merged

Add function ready status in describe output#3627
knative-prow[bot] merged 1 commit intoknative:mainfrom
creydr:add-function-status-in-describe-output

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Apr 21, 2026

It'd be nice to see in the output of func describe to see if a function is ready or not like we have in func list:

$ func list                     
NAME     NAMESPACE  RUNTIME  DEPLOYER  URL                                       READY
my-func  default             knative   http://my-func.default.svc.cluster.local  False

This PR addresses it and adds it to the output:

$ func describe my-func                             
Function name:
  my-func
Function is built in image:
 localhost:5001/my-func@sha256:10c2f7cd025266811b9482ae7014b8b293b9a3c78d41d8ab92b0deacf0e37cd1
Function is deployed in namespace:
  default
Routes:
  http://my-func.default.svc.cluster.local
Function is ready:
  false
Deployer:
  knative
Labels:
  boson.dev/function: true
  function.knative.dev/name: my-func
  function.knative.dev/runtime: go

$ func describe my-func -o yaml                     
route: http://my-func.default.svc.cluster.local
...
ready: "false"

Changes

  • 🎁 Add function status in describe output

/kind enhancement

Release Note

Provide functions ready status in "func describe" output

@knative-prow knative-prow Bot added the kind/enhancement Feature additions or improvements to existing label Apr 21, 2026
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos April 21, 2026 11:12
@knative-prow knative-prow Bot added the size/M 🤖 PR changes 30-99 lines, ignoring generated files. label Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.32%. Comparing base (50215d6) to head (78688d4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/keda/describer.go 57.14% 2 Missing and 1 partial ⚠️
cmd/describe.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3627      +/-   ##
==========================================
+ Coverage   55.61%   56.32%   +0.70%     
==========================================
  Files         180      180              
  Lines       20549    20571      +22     
==========================================
+ Hits        11429    11586     +157     
+ Misses       7960     7782     -178     
- Partials     1160     1203      +43     
Flag Coverage Δ
e2e 36.20% <27.27%> (-0.02%) ⬇️
e2e go 32.86% <28.57%> (?)
e2e node 28.62% <28.57%> (-0.01%) ⬇️
e2e python 33.23% <28.57%> (?)
e2e quarkus 28.76% <28.57%> (?)
e2e rust 28.16% <28.57%> (?)
e2e springboot 26.65% <28.57%> (+0.02%) ⬆️
e2e typescript 28.73% <28.57%> (-0.01%) ⬇️
e2e-config-ci 18.05% <0.00%> (-0.03%) ⬇️
integration 17.57% <76.19%> (+0.10%) ⬆️
unit macos-14 43.31% <9.52%> (-0.04%) ⬇️
unit macos-latest 43.31% <9.52%> (-0.05%) ⬇️
unit ubuntu-24.04-arm 43.51% <9.09%> (-0.04%) ⬇️
unit ubuntu-latest 44.18% <9.52%> (-0.05%) ⬇️
unit windows-latest 43.34% <9.52%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Apr 21, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@knative-prow knative-prow Bot merged commit 87ce20d into knative:main Apr 21, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. kind/enhancement Feature additions or improvements to existing lgtm 🤖 PR is ready to be merged. size/M 🤖 PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants