Skip to content

Remove nested git repository from pipelines tests#3628

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
lkingland:push-kysmmqnynuyn
Apr 21, 2026
Merged

Remove nested git repository from pipelines tests#3628
knative-prow[bot] merged 1 commit intoknative:mainfrom
lkingland:push-kysmmqnynuyn

Conversation

@lkingland
Copy link
Copy Markdown
Member

Nested git repositories cause problems with a plethora of tools.

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos April 21, 2026 11:32
@knative-prow knative-prow Bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/S 🤖 PR changes 10-29 lines, ignoring generated files. labels Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.29%. Comparing base (50215d6) to head (10a1afa).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3628      +/-   ##
==========================================
+ Coverage   55.61%   56.29%   +0.67%     
==========================================
  Files         180      180              
  Lines       20549    20549              
==========================================
+ Hits        11429    11568     +139     
+ Misses       7960     7779     -181     
- Partials     1160     1202      +42     
Flag Coverage Δ
e2e 36.21% <ø> (ø)
e2e go 32.86% <ø> (?)
e2e node 28.62% <ø> (ø)
e2e python 33.23% <ø> (?)
e2e quarkus 28.76% <ø> (?)
e2e rust 28.18% <ø> (?)
e2e springboot 26.62% <ø> (ø)
e2e typescript 28.73% <ø> (ø)
e2e-config-ci 18.08% <ø> (ø)
integration 17.50% <ø> (+0.03%) ⬆️
unit macos-14 43.35% <ø> (+<0.01%) ⬆️
unit macos-latest 43.35% <ø> (ø)
unit ubuntu-24.04-arm 43.55% <ø> (ø)
unit ubuntu-latest 44.23% <ø> (ø)
unit windows-latest 43.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label Apr 21, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit 8ea6305 into knative:main Apr 21, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants