Skip to content

fix nightly build#3653

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:fix-presubmits
May 1, 2026
Merged

fix nightly build#3653
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:fix-presubmits

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented May 1, 2026

Fix the nightly build - it runs build tests which does a go-licenses check and requires us to ignore a test library that it can't infer the license for

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 1, 2026 15:37
@knative-prow knative-prow Bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/XS 🤖 PR changes 0-9 lines, ignoring generated files. labels May 1, 2026
@nader-ziada
Copy link
Copy Markdown
Member

/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label May 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.45%. Comparing base (5bb0257) to head (4d4fa73).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   56.46%   56.45%   -0.01%     
==========================================
  Files         181      181              
  Lines       20674    20674              
==========================================
- Hits        11673    11672       -1     
- Misses       7789     7790       +1     
  Partials     1212     1212              
Flag Coverage Δ
e2e 36.30% <ø> (-0.03%) ⬇️
e2e go 33.02% <ø> (ø)
e2e node 28.79% <ø> (ø)
e2e python 33.39% <ø> (ø)
e2e quarkus 28.93% <ø> (+0.02%) ⬆️
e2e rust 28.32% <ø> (-0.02%) ⬇️
e2e springboot 26.81% <ø> (+0.02%) ⬆️
e2e typescript 28.89% <ø> (ø)
e2e-config-ci 18.11% <ø> (ø)
integration 17.46% <ø> (+0.01%) ⬆️
unit macos-14 43.53% <ø> (ø)
unit macos-latest 43.53% <ø> (ø)
unit ubuntu-24.04-arm 43.72% <ø> (ø)
unit ubuntu-latest 44.39% <ø> (ø)
unit windows-latest 43.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit 3804dc9 into knative:main May 1, 2026
40 checks passed
@dprotaso dprotaso deleted the fix-presubmits branch May 1, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants