Allow to specify ImagePullSecret

[creydr]

Changes

• 🎁 Allow to specify the image-pull-secret via the --image-pull-secret param

$ func deploy --image-pull-secret registry-credentials 
...

$ k get deploy my-func-00001-deployment -o yaml
      ...
      imagePullSecrets:
      - name: registry-credentials

$ cat func.yaml
...
deploy:
  ...
  imagePullSecret: registry-credentials

/kind enhancement

Release Note

Allow to specify the image-pull-secret via the --image-pull-secret param

[codecov]

Codecov Report

❌ Patch coverage is 75.51020% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.67%. Comparing base (d202fc9) to head (f889caf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/knative/deployer.go	75.86%	5 Missing and 2 partials ⚠️
pkg/k8s/deployer.go	58.33%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3656      +/-   ##
==========================================
+ Coverage   56.59%   56.67%   +0.08%     
==========================================
  Files         181      181              
  Lines       20694    20732      +38     
==========================================
+ Hits        11711    11750      +39     
+ Misses       7773     7770       -3     
- Partials     1210     1212       +2     

Flag	Coverage Δ
e2e	36.33% <38.77%> (+<0.01%)	⬆️
e2e go	33.01% <34.88%> (-0.02%)	⬇️
e2e node	28.70% <34.88%> (-0.03%)	⬇️
e2e python	33.38% <34.88%> (-0.02%)	⬇️
e2e quarkus	28.83% <34.88%> (-0.01%)	⬇️
e2e rust	28.25% <34.88%> (+0.01%)	⬆️
e2e springboot	26.71% <34.88%> (-0.03%)	⬇️
e2e typescript	28.81% <34.88%> (-0.01%)	⬇️
e2e-config-ci	18.02% <13.95%> (-0.03%)	⬇️
integration	17.43% <20.93%> (-0.02%)	⬇️
unit macos-14	44.26% <65.11%> (+0.57%)	⬆️
unit macos-latest	44.26% <65.11%> (+0.57%)	⬆️
unit ubuntu-24.04-arm	44.44% <65.30%> (+0.56%)	⬆️
unit ubuntu-latest	45.12% <65.11%> (+0.57%)	⬆️
unit windows-latest	44.25% <65.11%> (+0.57%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[creydr]

Can anybody check on this?
/cc @lkingland @gauron99 @matejvasek

[gauron99]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gauron99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment