fix: write func.yaml before remote deploy upload#3663
Open
creydr wants to merge 1 commit intoknative:mainfrom
Open
fix: write func.yaml before remote deploy upload#3663creydr wants to merge 1 commit intoknative:mainfrom
func.yaml before remote deploy upload#3663creydr wants to merge 1 commit intoknative:mainfrom
Conversation
Previously, func.yaml was only written to disk after deployment completed. For remote deploys, the pipeline uploads sources from disk to a PVC before the on-cluster deploy step runs. This meant CLI flags like --image-pull-secret, --service-account, or --deployer were not reflected in the uploaded func.yaml. Write func.yaml before the pipeline starts so the on-cluster deploy step sees the latest configuration.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
size/M
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3663 +/- ##
==========================================
+ Coverage 53.49% 56.70% +3.20%
==========================================
Files 181 181
Lines 20732 20738 +6
==========================================
+ Hits 11091 11759 +668
+ Misses 8567 7769 -798
- Partials 1074 1210 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
/cc @gauron99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
func.yamlwas only written to disk after deployment completed. For remote deploys, the pipeline uploads sources from disk to a PVC before the on-cluster deploy step runs. This meant CLI flags like--image-pull-secret,--service-account, or--deployerwere not reflected in the uploadedfunc.yaml.Write
func.yamlbefore the pipeline starts so the on-cluster deploy step sees the latest configuration.Changes
--image-pull-secretsupport on remote deploys/kind bug