Skip to content

test: add resource validation integration test to k8s and keda deployers#3670

Closed
matejvasek wants to merge 1 commit intoknative:mainfrom
matejvasek:secret-test
Closed

test: add resource validation integration test to k8s and keda deployers#3670
matejvasek wants to merge 1 commit intoknative:mainfrom
matejvasek:secret-test

Conversation

@matejvasek
Copy link
Copy Markdown
Contributor

@matejvasek matejvasek commented May 7, 2026

Summary

  • Wire up TestInt_ResourceValidationOnFirstDeploy for the k8s and keda deployers, matching the existing Knative deployer coverage
  • No new test logic — both delegate to the shared helper in pkg/deployer/testing

Test plan

  • Run go build -tags integration ./pkg/k8s/... ./pkg/keda/... to verify compilation
  • Run the integration test suite against a cluster with all three deployers

Ref #3514

@matejvasek @claude
test: add resource validation integration test to k8s and keda deployers
9ebecd0 
The TestInt_ResourceValidationOnFirstDeploy test was only wired up for
the Knative deployer. Add it to the k8s and keda deployer integration
test suites so all deployers are covered by the same regression test
for knative#3514.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 7, 2026 12:59
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/S 🤖 PR changes 10-29 lines, ignoring generated files. labels May 7, 2026
@matejvasek matejvasek mentioned this pull request May 7, 2026
Merged
@matejvasek
Copy link
Copy Markdown
Contributor Author

matejvasek commented May 7, 2026

/cc @Ankitsinghsisodya

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 7, 2026

@matejvasek: GitHub didn't allow me to request PR reviews from the following users: Ankitsinghsisodya.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Ankitsinghsisodya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek matejvasek requested review from creydr and gauron99 May 7, 2026 13:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.19%. Comparing base (33a9d85) to head (9ebecd0).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3670      +/-   ##
==========================================
- Coverage   56.61%   54.19%   -2.43%     
==========================================
  Files         181      181              
  Lines       20853    20853              
==========================================
- Hits        11806    11301     -505     
- Misses       7833     8437     +604     
+ Partials     1214     1115      -99
Flag Coverage Δ
e2e 36.24% <ø> (-0.02%) ⬇️
e2e go 32.91% <ø> (ø)
e2e node 28.62% <ø> (ø)
e2e python 33.28% <ø> (ø)
e2e quarkus 28.76% <ø> (ø)
e2e rust 28.16% <ø> (ø)
e2e springboot 26.65% <ø> (+0.02%) ⬆️
e2e typescript 28.73% <ø> (ø)
e2e-config-ci 17.98% <ø> (ø)
integration ?
unit macos-14 44.65% <ø> (ø)
unit macos-latest 44.65% <ø> (ø)
unit ubuntu-24.04-arm 44.90% <ø> (ø)
unit ubuntu-latest 45.51% <ø> (ø)
unit windows-latest 44.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Ankitsinghsisodya commented May 7, 2026

/cc @Ankitsinghsisodya

Sir, I have opened PR #3671 which is superset of this PR

@matejvasek
Copy link
Copy Markdown
Contributor Author

matejvasek commented May 7, 2026

/hold

@knative-prow knative-prow Bot added the do-not-merge/hold 🤖 PR should not merge because someone has issued a /hold command. label May 7, 2026
@matejvasek matejvasek closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@creydr creydr Awaiting requested review from creydr

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

No one assigned

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. do-not-merge/hold 🤖 PR should not merge because someone has issued a /hold command. size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matejvasek @Ankitsinghsisodya