-
Notifications
You must be signed in to change notification settings - Fork 188
Port automation scripts from JavaScript to Go #3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ankitsinghsisodya
wants to merge
4
commits into
knative:main
Choose a base branch
from
Ankitsinghsisodya:fix/2815-port-js-scripts-to-go
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5c16100
Add automation commands for updating platform versions and CA bundle
Ankitsinghsisodya a40ba41
Refactor automation scripts for platform updates and CA bundle manage…
Ankitsinghsisodya 8ed0f93
fix(workflows): gate smoke tests and PR creation on actual file changes
Ankitsinghsisodya 4f9a839
fix: use package dir in go run and rename shared/github.go
Ankitsinghsisodya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package shared | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "net/http" | ||
| "os" | ||
| "os/exec" | ||
| "strings" | ||
| "time" | ||
| ) | ||
|
|
||
| // HTTPClient is used for all outbound HTTP requests; has a 30-second timeout. | ||
| var HTTPClient = &http.Client{Timeout: 30 * time.Second} | ||
|
|
||
| // RunCmd runs name with args, streaming stdout/stderr to the process output. | ||
| func RunCmd(ctx context.Context, name string, args ...string) error { | ||
| cmd := exec.CommandContext(ctx, name, args...) | ||
| cmd.Stdout = os.Stdout | ||
| cmd.Stderr = os.Stderr | ||
| if err := cmd.Run(); err != nil { | ||
| return fmt.Errorf("command %q failed: %w", name+" "+strings.Join(args, " "), err) | ||
| } | ||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "os" | ||
| "os/signal" | ||
| "syscall" | ||
|
|
||
| "knative.dev/func/hack/cmd/shared" | ||
| ) | ||
|
|
||
| const caBundleMakeTarget = "templates/certs/ca-certificates.crt" | ||
|
|
||
| func main() { | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| sigs := make(chan os.Signal, 1) | ||
| signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM) | ||
| go func() { | ||
| <-sigs | ||
| cancel() | ||
| <-sigs | ||
| os.Exit(130) | ||
| }() | ||
|
|
||
| if err := run(ctx); err != nil { | ||
| fmt.Fprintf(os.Stderr, "ERROR: %v\n", err) | ||
| os.Exit(1) | ||
| } | ||
| } | ||
|
|
||
| func run(ctx context.Context) error { | ||
| return shared.RunCmd(ctx, "make", caBundleMakeTarget) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "net/http" | ||
| "os" | ||
| "os/signal" | ||
| "regexp" | ||
| "syscall" | ||
|
|
||
| "knative.dev/func/hack/cmd/shared" | ||
| ) | ||
|
|
||
| const ( | ||
| cePomPath = "templates/quarkus/cloudevents/pom.xml" | ||
| httpPomPath = "templates/quarkus/http/pom.xml" | ||
|
|
||
| quarkusPlatformAPI = "https://code.quarkus.io/api/platforms" | ||
|
|
||
| quarkusVersionTag = "quarkus.platform.version" | ||
| quarkusVersionExpr = `<quarkus\.platform\.version>([^<]+)</quarkus\.platform\.version>` | ||
| ) | ||
|
|
||
| var quarkusVersionRe = regexp.MustCompile(quarkusVersionExpr) | ||
|
|
||
| type quarkusPlatformResponse struct { | ||
| Platforms []struct { | ||
| Streams []struct { | ||
| Releases []struct { | ||
| QuarkusCoreVersion string `json:"quarkusCoreVersion"` | ||
| } `json:"releases"` | ||
| } `json:"streams"` | ||
| } `json:"platforms"` | ||
| } | ||
|
|
||
| func main() { | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| sigs := make(chan os.Signal, 1) | ||
| signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM) | ||
| go func() { | ||
| <-sigs | ||
| cancel() | ||
| <-sigs | ||
| os.Exit(130) | ||
| }() | ||
|
|
||
| if err := run(ctx); err != nil { | ||
| fmt.Fprintf(os.Stderr, "ERROR: %v\n", err) | ||
| os.Exit(1) | ||
| } | ||
| } | ||
|
|
||
| func run(ctx context.Context) error { | ||
| latestVersion, err := getLatestQuarkusVersion(ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("cannot get latest Quarkus platform version: %w", err) | ||
| } | ||
| fmt.Printf("Latest Quarkus platform version: %s\n", latestVersion) | ||
|
|
||
| ceVersion, err := versionFromPOM(cePomPath) | ||
| if err != nil { | ||
| return fmt.Errorf("cannot read version from %s: %w", cePomPath, err) | ||
| } | ||
| httpVersion, err := versionFromPOM(httpPomPath) | ||
| if err != nil { | ||
| return fmt.Errorf("cannot read version from %s: %w", httpPomPath, err) | ||
| } | ||
|
|
||
| if ceVersion == latestVersion && httpVersion == latestVersion { | ||
| fmt.Println("Quarkus platform is up-to-date!") | ||
| return nil | ||
| } | ||
|
|
||
| for _, pomPath := range []string{cePomPath, httpPomPath} { | ||
| if err := updatePOM(pomPath, latestVersion); err != nil { | ||
| return fmt.Errorf("cannot update %s: %w", pomPath, err) | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func getLatestQuarkusVersion(ctx context.Context) (string, error) { | ||
| req, err := http.NewRequestWithContext(ctx, http.MethodGet, quarkusPlatformAPI, nil) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| resp, err := shared.HTTPClient.Do(req) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| return "", fmt.Errorf("unexpected status %d from %s", resp.StatusCode, quarkusPlatformAPI) | ||
| } | ||
|
|
||
| var data quarkusPlatformResponse | ||
| if err := json.NewDecoder(resp.Body).Decode(&data); err != nil { | ||
| return "", err | ||
| } | ||
| if len(data.Platforms) == 0 || | ||
| len(data.Platforms[0].Streams) == 0 || | ||
| len(data.Platforms[0].Streams[0].Releases) == 0 { | ||
| return "", fmt.Errorf("unexpected response structure from Quarkus platform API") | ||
| } | ||
| v := data.Platforms[0].Streams[0].Releases[0].QuarkusCoreVersion | ||
| if v == "" { | ||
| return "", fmt.Errorf("quarkusCoreVersion is empty in API response") | ||
| } | ||
| return v, nil | ||
| } | ||
|
|
||
| func versionFromPOM(path string) (string, error) { | ||
| data, err := os.ReadFile(path) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| m := quarkusVersionRe.FindSubmatch(data) | ||
| if len(m) < 2 { | ||
| return "", fmt.Errorf("cannot find <%s> in %s", quarkusVersionTag, path) | ||
| } | ||
| return string(m[1]), nil | ||
| } | ||
|
|
||
| func updatePOM(path, newVersion string) error { | ||
| data, err := os.ReadFile(path) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| updated := quarkusVersionRe.ReplaceAll(data, | ||
| []byte(fmt.Sprintf("<%s>%s</%s>", quarkusVersionTag, newVersion, quarkusVersionTag))) | ||
| return os.WriteFile(path, updated, 0644) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.