cmd/mcp: pass WithReadonly at construction to fix instructions desync

[Elvand-Lie]

The MCP server instructions were computed at New() time before Start() set the readonly flag. This meant the readonly warning was never included in instructions sent to MCP clients, even when the server was running in readonly mode.

Pass WithReadonly(!writeEnabled) at construction time so the instructions correctly reflect the runtime readonly state.

Changes

• Pass mcp.WithReadonly(!writeEnabled) to mcp.New() in cmd/mcp.go

Fixes #3703

Release Note

Docs

[knative-prow]

Hi @Elvand-Lie. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.90%. Comparing base (2b6fb02) to head (0c54c83).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3707      +/-   ##
==========================================
- Coverage   56.91%   56.90%   -0.02%     
==========================================
  Files         181      181              
  Lines       20928    20930       +2     
==========================================
- Hits        11912    11910       -2     
- Misses       7808     7810       +2     
- Partials     1208     1210       +2     

Flag	Coverage Δ
e2e	36.15% <0.00%> (-0.01%)	⬇️
e2e go	32.75% <0.00%> (-0.01%)	⬇️
e2e node	28.48% <0.00%> (-0.01%)	⬇️
e2e python	33.11% <0.00%> (-0.02%)	⬇️
e2e quarkus	28.62% <0.00%> (-0.01%)	⬇️
e2e rust	28.02% <0.00%> (-0.01%)	⬇️
e2e springboot	26.49% <0.00%> (-0.02%)	⬇️
e2e typescript	28.58% <0.00%> (-0.01%)	⬇️
e2e-config-ci	17.87% <0.00%> (-0.01%)	⬇️
integration	17.41% <0.00%> (-0.03%)	⬇️
unit macos-14	44.99% <100.00%> (+<0.01%)	⬆️
unit macos-latest	44.99% <100.00%> (+<0.01%)	⬆️
unit ubuntu-24.04-arm	45.16% <100.00%> (+<0.01%)	⬆️
unit ubuntu-latest	45.84% <100.00%> (+<0.01%)	⬆️
unit windows-latest	44.98% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gauron99]

/ok-to-test
/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elvand-Lie, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gauron99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gauron99]

/retest