fix(mcp): correct Server.readonly field comment#3740
Conversation
Updated the comment for the readonly field in the Server struct to specify that it disables deploy and delete operations when set to true, enhancing code clarity and documentation accuracy.
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3740 +/- ##
==========================================
+ Coverage 56.95% 56.97% +0.02%
==========================================
Files 181 181
Lines 21116 21116
==========================================
+ Hits 12026 12031 +5
+ Misses 7866 7862 -4
+ Partials 1224 1223 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Corrects the
Server.readonlystruct field comment inpkg/mcp/mcp.go. The field is used to block deploy and delete when true; the previous comment described the opposite behavior.Motivation
Misleading comments confuse contributors and anyone tracing read-only MCP behavior.
Changes
pkg/mcp/mcp.go: updatereadonlycomment to state that deploy and delete are disabled whenreadonlyis true.