Skip to content

fix(mcp): correct Server.readonly field comment#3740

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
Ankitsinghsisodya:fix/mcp-readonly-comment
May 15, 2026
Merged

fix(mcp): correct Server.readonly field comment#3740
knative-prow[bot] merged 1 commit into
knative:mainfrom
Ankitsinghsisodya:fix/mcp-readonly-comment

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Summary

Corrects the Server.readonly struct field comment in pkg/mcp/mcp.go. The field is used to block deploy and delete when true; the previous comment described the opposite behavior.

Motivation

Misleading comments confuse contributors and anyone tracing read-only MCP behavior.

Changes

  • pkg/mcp/mcp.go: update readonly comment to state that deploy and delete are disabled when readonly is true.

Updated the comment for the readonly field in the Server struct to specify that it disables deploy and delete operations when set to true, enhancing code clarity and documentation accuracy.
Copilot AI review requested due to automatic review settings May 14, 2026 23:32
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 14, 2026 23:32
@knative-prow knative-prow Bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels May 14, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 14, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.97%. Comparing base (e435a89) to head (ceb8dc2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3740      +/-   ##
==========================================
+ Coverage   56.95%   56.97%   +0.02%     
==========================================
  Files         181      181              
  Lines       21116    21116              
==========================================
+ Hits        12026    12031       +5     
+ Misses       7866     7862       -4     
+ Partials     1224     1223       -1     
Flag Coverage Δ
e2e 35.81% <ø> (-0.01%) ⬇️
e2e go 32.42% <ø> (ø)
e2e node 28.20% <ø> (ø)
e2e python 32.80% <ø> (ø)
e2e quarkus 28.34% <ø> (ø)
e2e rust 27.75% <ø> (?)
e2e springboot 26.26% <ø> (ø)
e2e typescript 28.30% <ø> (-0.03%) ⬇️
e2e-config-ci 17.70% <ø> (ø)
integration 17.28% <ø> (-0.02%) ⬇️
unit macos-14 45.05% <ø> (ø)
unit macos-latest 45.05% <ø> (ø)
unit ubuntu-24.04-arm 45.32% <ø> (ø)
unit ubuntu-latest 46.00% <ø> (ø)
unit windows-latest 45.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label May 15, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitsinghsisodya, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@knative-prow knative-prow Bot merged commit 0f032d5 into knative:main May 15, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants