docs(cmd): fix stale runMCPServer reference in mcp start comment#3742
Conversation
Changed the comment in cmd/mcp.go to reflect the correct function name for gathering options, updating from runMCPServer to runMCPStart. This improves clarity for future enhancements related to MCP server configuration.
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates a code comment in cmd/mcp.go to reference the renamed function runMCPStart instead of runMCPServer.
Changes:
- Comment-only update reflecting a function rename.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
+ Coverage 56.95% 56.96% +0.01%
==========================================
Files 181 181
Lines 21116 21116
==========================================
+ Hits 12026 12029 +3
+ Misses 7866 7863 -3
Partials 1224 1224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/retest |
Summary
Updates an inline comment in
cmd/mcp.gothat referred to a non-existentrunMCPServerhelper. The actual entry point isrunMCPStart.Motivation
Stale names in comments mislead readers when tracing how
mcp startis wired.Changes
cmd/mcp.go: comment underNewMCPStartCmdnow referencesrunMCPStart.Testing
make check/go test ./cmd/...