mcp: expose server version in healthcheck output#3745
Conversation
|
Hi @cubaseuser123. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cubaseuser123, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3745 +/- ##
==========================================
+ Coverage 56.95% 56.96% +0.01%
==========================================
Files 181 181
Lines 21116 21117 +1
==========================================
+ Hits 12026 12030 +4
+ Misses 7866 7863 -3
Partials 1224 1224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
Was going through the
mcppackage exploring the codebase, and I noticed thehealthchecktool only returns{ "status": "ok", "message": "..." }.Agents currently have no way to know which version of
knative-funcis running the server. Maybe an outdated binary could run against a new cluster and behave differently, so an agent needs to have the version number to debug that.mcp.goalready defines a package-levelversionconstant (used during handshake). This PR just takes that existing constant into theHealthcheckOutputso agents have immediate version context during healthchecks.This PR:
Versionfield toHealthcheckOutputand populates it.TestTool_Healthcheck./kind enhancement
There is no open issue for this; I found it during a codebase review. But I recently made another PR #3724.
I ran the test suite and everything runs ok for me locally. Let me know if any changes are required.
Release Note