Skip to content

mcp: expose server version in healthcheck output#3745

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
cubaseuser123:mcp/healthcheck-version
May 15, 2026
Merged

mcp: expose server version in healthcheck output#3745
knative-prow[bot] merged 1 commit into
knative:mainfrom
cubaseuser123:mcp/healthcheck-version

Conversation

@cubaseuser123
Copy link
Copy Markdown
Contributor

@cubaseuser123 cubaseuser123 commented May 15, 2026

Changes

Was going through the mcp package exploring the codebase, and I noticed the healthcheck tool only returns { "status": "ok", "message": "..." }.

Agents currently have no way to know which version of knative-func is running the server. Maybe an outdated binary could run against a new cluster and behave differently, so an agent needs to have the version number to debug that.

mcp.go already defines a package-level version constant (used during handshake). This PR just takes that existing constant into the HealthcheckOutput so agents have immediate version context during healthchecks.

This PR:

  • Adds a Version field to HealthcheckOutput and populates it.
  • Adds the corresponding non-empty assertion to TestTool_Healthcheck.

/kind enhancement

There is no open issue for this; I found it during a codebase review. But I recently made another PR #3724.

I ran the test suite and everything runs ok for me locally. Let me know if any changes are required.

Release Note


@knative-prow knative-prow Bot added the kind/enhancement Feature additions or improvements to existing label May 15, 2026
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 15, 2026 06:36
@knative-prow knative-prow Bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label May 15, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 15, 2026

Hi @cubaseuser123. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label May 15, 2026
@matejvasek
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels May 15, 2026
@matejvasek
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@knative-prow knative-prow Bot added the lgtm 🤖 PR is ready to be merged. label May 15, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cubaseuser123, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.96%. Comparing base (e435a89) to head (8b7645a).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3745      +/-   ##
==========================================
+ Coverage   56.95%   56.96%   +0.01%     
==========================================
  Files         181      181              
  Lines       21116    21117       +1     
==========================================
+ Hits        12026    12030       +4     
+ Misses       7866     7863       -3     
  Partials     1224     1224              
Flag Coverage Δ
e2e 35.79% <0.00%> (-0.03%) ⬇️
e2e go 32.42% <0.00%> (-0.01%) ⬇️
e2e node 28.20% <0.00%> (-0.01%) ⬇️
e2e python 32.80% <0.00%> (-0.01%) ⬇️
e2e quarkus 28.34% <0.00%> (-0.01%) ⬇️
e2e rust 27.75% <0.00%> (?)
e2e springboot 26.26% <0.00%> (-0.01%) ⬇️
e2e typescript 28.30% <0.00%> (-0.03%) ⬇️
e2e-config-ci 17.70% <0.00%> (-0.01%) ⬇️
integration 17.30% <0.00%> (-0.01%) ⬇️
unit macos-14 45.05% <100.00%> (+<0.01%) ⬆️
unit macos-latest 45.05% <100.00%> (+<0.01%) ⬆️
unit ubuntu-24.04-arm 45.32% <100.00%> (+<0.01%) ⬆️
unit ubuntu-latest 46.01% <100.00%> (+<0.01%) ⬆️
unit windows-latest 45.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Copy Markdown
Contributor

@knative-prow knative-prow Bot merged commit b080440 into knative:main May 15, 2026
86 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. kind/enhancement Feature additions or improvements to existing lgtm 🤖 PR is ready to be merged. ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants