fix(keda): add defensive length check when accessing service Ports

[Elvand-Lie]

Problem

In pkg/keda/deployer.go, the code accesses service.Spec.Ports[0].Port to build the HTTP ScaledObject. The service object is fetched live from the Kubernetes cluster.

While the upstream deployers will always generate a service with exactly one port during normal operations, this code lacks a defensive length check on the Ports slice. If a user or an external controller manually modifies the service in the cluster to remove its ports, the KEDA deployer will crash with an out of bounds panic during reconciliation.

Fix

Added a defensive check for len(service.Spec.Ports) > 0 to prevent this.

Fixes #3812

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elvand-Lie
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Hi @Elvand-Lie. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.41%. Comparing base (ad6edb6) to head (9092f58).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/keda/deployer.go	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
- Coverage   53.42%   53.41%   -0.02%     
==========================================
  Files         200      200              
  Lines       23426    23429       +3     
==========================================
- Hits        12515    12514       -1     
- Misses       9655     9658       +3     
- Partials     1256     1257       +1     

Flag	Coverage Δ
e2e	33.68% <0.00%> (-0.01%)	⬇️
e2e go	29.64% <0.00%> (-0.01%)	⬇️
e2e node	25.86% <0.00%> (-0.01%)	⬇️
e2e python	29.97% <0.00%> (-0.01%)	⬇️
e2e quarkus	25.97% <0.00%> (-0.01%)	⬇️
e2e rust	25.42% <0.00%> (-0.03%)	⬇️
e2e springboot	24.09% <0.00%> (-0.03%)	⬇️
e2e typescript	25.96% <0.00%> (-0.01%)	⬇️
e2e-config-ci	26.75% <0.00%> (-0.01%)	⬇️
integration	15.60% <0.00%> (-0.02%)	⬇️
unit macos-14	42.19% <0.00%> (-0.01%)	⬇️
unit macos-latest	42.19% <0.00%> (-0.01%)	⬇️
unit ubuntu-24.04-arm	42.50% <0.00%> (-0.01%)	⬇️
unit ubuntu-latest	43.06% <0.00%> (-0.01%)	⬇️
unit windows-latest	42.23% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.