feat!: support on cluster build from git repo with Tekton

[zroubalik]

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Changes

• 🎁 support on cluster build from git repo with Tekton
• func deploy --build originally accepted true or false, now it accepts disabled, local or git values

/kind enhancement

on-cluster-git.mp4

Fixes: #748

Adds the ability to build a Function on the cluster using Tekton Pipelines. The build on the cluster is enabled by fetching Function source code from a remote Git repository.

[codecov]

Codecov Report

Merging #743 (c661d6f) into main (64ba17b) will decrease coverage by 0.27%.
The diff coverage is 35.77%.

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   41.52%   41.25%   -0.28%     
==========================================
  Files          42       44       +2     
  Lines        4101     4208     +107     
==========================================
+ Hits         1703     1736      +33     
- Misses       2145     2217      +72     
- Partials      253      255       +2     

Impacted Files	Coverage Δ
knative/deployer.go	5.59% <0.00%> (ø)
cmd/deploy.go	12.59% <1.66%> (-3.30%)	⬇️
client.go	60.86% <42.30%> (-3.42%)	⬇️
function.go	55.00% <71.42%> (+0.86%)	⬆️
function_git.go	83.33% <83.33%> (ø)
function_buildtype.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ba17b...c661d6f. Read the comment docs.

[matejvasek]

@zroubalik please fix the e2e tests (Error: specified build type "false" is not valid, allowed build types are "disabled", "local" or "git") and generated files ./hack/update-deps.sh.

[zroubalik]

@zroubalik please fix the e2e tests (Error: specified build type "false" is not valid, allowed build types are "disabled", "local" or "git") and generated files ./hack/update-deps.sh.

@matejvasek thanks for the review, I have fixed the problems.

Though ./hack/update-deps.sh or ``./hack/update-codegen.sh` haven't done anything 🤷‍♂️ Not sure how to fix the validation problem.

[matejvasek]

Though ./hack/update-deps.sh or ``./hack/update-codegen.sh` haven't done anything 🤷‍♂️ Not sure how to fix the validation problem.

I think that @lkingland had similar issue on macOS.
For me the update removed this file: third_party/VENDOR-LICENSE/github.com/opencontainers/selinux/go-selinux/LICENSE.

[matejvasek]

@zroubalik also would it be possible to add some e2e test for in cluster build?

[zroubalik]

@zroubalik also would it be possible to add some e2e test for in cluster build?

Yeah, definitely. But I don't want to bloat this PR. I will create a few follow up issues(tasks) that need to be done for this feature.

[zroubalik]

@zroubalik try cherry-picking this: matejvasek@312b6e3.

@matejvasek seems like it helped, thanks a lot :)

[zroubalik]

/hold

[lkingland]

Looks really good, and I know this represents just the tip of the iceberg!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zroubalik]

/unhold

[zroubalik]

/hold

need to get #740 merged first

[matejvasek]

When running build user is asked about registry URL, but isn't that known from func.yaml? @zroubalik

Wouldn't it be possible to use existing credential provider? It could read credentials automatically form developer machine, but I am not sure whether it would be good thing.

[zroubalik]

When running build user is asked about registry URL, but isn't that known from func.yaml? @zroubalik

Wouldn't it be possible to use existing credential provider? It could read credentials automatically form developer machine, but I am not sure whether it would be good thing.

@matejvasek wrt registry url, yeah we should try to guess it from registry. And getting credentials automatically would be great, I am not sure if that's possible.

I have captured both of these features in the Task list in #620.
(On-cluster build: Try to get registry credentials from a local developer machine, On-cluster build: Try to suggest correct Server name for Image Registry Credentials prompt)

[matejvasek]

And getting credentials automatically would be great, I am not sure if that's possible.

Couldn't we use https://github.com/knative-sandbox/kn-plugin-func/blob/main/docker/creds/credentials.go#L153 @zroubalik ?

[zroubalik]

And getting credentials automatically would be great, I am not sure if that's possible.

Couldn't we use https://github.com/knative-sandbox/kn-plugin-func/blob/main/docker/creds/credentials.go#L153 @zroubalik ?

Probably yes :) Are you willing to implement this? If so, feel free to covert that task into an issue. It will be more than welcome :)

[lance]

/lgtm

[lance]

/unhold

[zroubalik]

/unhold