feat: add a label to every resouce created for a Function#757
Merged
knative-prow-robot merged 1 commit intoknative:mainfrom Jan 13, 2022
Merged
feat: add a label to every resouce created for a Function#757knative-prow-robot merged 1 commit intoknative:mainfrom
knative-prow-robot merged 1 commit intoknative:mainfrom
Conversation
knative-prow-robot
added
the
kind/enhancement
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/M
Codecov Report
@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 41.40% 41.39% -0.01%
==========================================
Files 44 44
Lines 4176 4177 +1
==========================================
Hits 1729 1729
- Misses 2191 2192 +1
Partials 256 256
Continue to review full report at Codecov.
|
knative-prow-robot
added
the
needs-rebase
…souce created for a Function Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
knative-prow-robot
removed
the
needs-rebase
Contributor
|
/lgtm |
knative-prow-robot
added
the
do-not-merge/hold
Contributor
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
jrangelramos
added a commit
to jrangelramos/func
that referenced
this pull request
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
Adding a label
function.knative.dev/name: functionNameto every resouce created for a Function, so we can easily identify them.Changes
/kind enhancement
Fixes: #753