fix check_licenses GOTOOLCHAIN mismatch with go-licenses#464
Open
kahirokunn wants to merge 1 commit intoknative:mainfrom
Open
fix check_licenses GOTOOLCHAIN mismatch with go-licenses#464kahirokunn wants to merge 1 commit intoknative:mainfrom
kahirokunn wants to merge 1 commit intoknative:mainfrom
Conversation
Pin GOTOOLCHAIN to the project's Go version in check_licenses() so that go-licenses is compiled with the same toolchain as the project. When GOTOOLCHAIN=auto (the go_run default), Go may select a different toolchain to build go-licenses, causing its isStdLib() check to fail with "does not have module info" errors for standard library packages.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
the
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_licenses()can fail whenGOTOOLCHAIN=autocausesgo-licensestobe built with a different toolchain than the project, resulting in stdlib
packages being misidentified.
Fix by pinning
GOTOOLCHAINto$(go env GOVERSION)incheck_licenses().