[release-1.17] Watch and reconcile operator-controller ConfigMaps#2063
Closed
knative-prow-robot wants to merge 2 commits intoknative:release-1.17from
Closed
[release-1.17] Watch and reconcile operator-controller ConfigMaps#2063knative-prow-robot wants to merge 2 commits intoknative:release-1.17from
knative-prow-robot wants to merge 2 commits intoknative:release-1.17from
Conversation
If users apply configmap changes directly, the operator wasn't reverting those changes instantly; with this PR, it will watch applied ConfigMaps and apply `KnativeServing` and `KnativeEventing` configurations. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knative-prow-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
size/L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.17 #2063 +/- ##
================================================
- Coverage 62.81% 62.16% -0.66%
================================================
Files 49 49
Lines 2294 2318 +24
================================================
Hits 1441 1441
- Misses 761 785 +24
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2062