Skip to content

[WIP] Add multi-cluster deployment support via Cluster Inventory API#2267

Open
kahirokunn wants to merge 7 commits intoknative:mainfrom
kahirokunn:multi-cluster-support
Open

[WIP] Add multi-cluster deployment support via Cluster Inventory API#2267
kahirokunn wants to merge 7 commits intoknative:mainfrom
kahirokunn:multi-cluster-support

Conversation

@kahirokunn
Copy link
Copy Markdown
Member

@kahirokunn kahirokunn commented Apr 6, 2026

Fixes #2264

Proposed Changes

Release Note


@knative-prow knative-prow bot requested review from houshengbo and matzew April 6, 2026 10:34
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 6, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kahirokunn: 0 warnings.

Details

In response to this:

Fixes #

Proposed Changes

Release Note


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 45.52239% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.78%. Comparing base (e397696) to head (7d7ee32).

Files with missing lines Patch % Lines
pkg/reconciler/common/multicluster.go 46.01% 56 Missing and 5 partials ⚠️
cmd/operator/main.go 0.00% 4 Missing ⚠️
pkg/reconciler/knativeeventing/controller.go 0.00% 3 Missing ⚠️
pkg/reconciler/knativeserving/controller.go 0.00% 3 Missing ⚠️
pkg/apis/operator/base/common.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2267      +/-   ##
==========================================
- Coverage   63.97%   62.78%   -1.20%     
==========================================
  Files          51       52       +1     
  Lines        1960     2088     +128     
==========================================
+ Hits         1254     1311      +57     
- Misses        605      671      +66     
- Partials      101      106       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kahirokunn kahirokunn changed the title Add multi-cluster deployment support via Cluster Inventory API [WIP] Add multi-cluster deployment support via Cluster Inventory API Apr 6, 2026
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2026
@kahirokunn kahirokunn force-pushed the multi-cluster-support branch 5 times, most recently from 3e585a9 to 141c875 Compare April 7, 2026 06:40
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2026
@kahirokunn kahirokunn force-pushed the multi-cluster-support branch 2 times, most recently from d308bf0 to 3e742cb Compare April 7, 2026 12:53
@kahirokunn kahirokunn changed the title [WIP] Add multi-cluster deployment support via Cluster Inventory API Add multi-cluster deployment support via Cluster Inventory API Apr 7, 2026
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2026
@kahirokunn kahirokunn force-pushed the multi-cluster-support branch from 3e742cb to 43919c6 Compare April 7, 2026 14:11
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2026
@kahirokunn kahirokunn force-pushed the multi-cluster-support branch from 43919c6 to 28a1e02 Compare April 7, 2026 14:22
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2026
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn kahirokunn force-pushed the multi-cluster-support branch from 28a1e02 to 88410ef Compare April 7, 2026 14:46
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 7, 2026

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2026
@kahirokunn kahirokunn changed the title Add multi-cluster deployment support via Cluster Inventory API [WIP] Add multi-cluster deployment support via Cluster Inventory API Apr 7, 2026
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2026
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Made-with: Cursor
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 7, 2026

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 7, 2026

@kahirokunn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_operator_main 7d7ee32 link true /test build-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multi-cluster deployment via Cluster Inventory API

2 participants