Skip to content

Install Gateway API CRDs for multicluster tests#2288

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
kahirokunn:fix/spoke-gateway-api-crds-main
Apr 30, 2026
Merged

Install Gateway API CRDs for multicluster tests#2288
knative-prow[bot] merged 1 commit intoknative:mainfrom
kahirokunn:fix/spoke-gateway-api-crds-main

Conversation

@kahirokunn
Copy link
Copy Markdown
Member

@kahirokunn kahirokunn commented Apr 30, 2026

What

  • Install Gateway API v1.4.1 experimental CRDs on the spoke kind cluster during multicluster e2e setup.
  • Wait for the GatewayClass, Gateway, HTTPRoute, and ReferenceGrant CRDs to become Established before wiring the ClusterProfile.

Why

The multicluster Serving test enables net-gateway-api on the spoke cluster, but the spoke cluster did not install Gateway API CRDs first. With the 1.22 net-gateway-api controller manifest, the controller exposes readiness/liveness probes and stays unavailable when the required Gateway API resources are missing.

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 30, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2026
@knative-prow knative-prow Bot requested review from aliok and houshengbo April 30, 2026 07:32
@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 30, 2026
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn kahirokunn force-pushed the fix/spoke-gateway-api-crds-main branch from 3ae601a to f90afb4 Compare April 30, 2026 07:34
@kahirokunn kahirokunn marked this pull request as ready for review April 30, 2026 07:35
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2026
@knative-prow knative-prow Bot requested a review from matzew April 30, 2026 07:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.84%. Comparing base (641e806) to head (f90afb4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2288   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          55       55           
  Lines        2478     2478           
=======================================
  Hits         1582     1582           
  Misses        777      777           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@houshengbo
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@knative-prow knative-prow Bot merged commit d1f9a68 into knative:main Apr 30, 2026
22 checks passed
@kahirokunn
Copy link
Copy Markdown
Member Author

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants