Skip to content

Restore operator CRD conversion webhooks#2293

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
kahirokunn:fix-static-crd-conversion-webhook
May 4, 2026
Merged

Restore operator CRD conversion webhooks#2293
knative-prow[bot] merged 1 commit intoknative:mainfrom
kahirokunn:fix-static-crd-conversion-webhook

Conversation

@kahirokunn
Copy link
Copy Markdown
Member

Fixes #

Proposed Changes

  • Restore the conversion webhook stanza in the generated KnativeServing and KnativeEventing CRD bases after controller-gen runs.
  • Make Helm CRD sync derive conversion settings from the CRD bases and only template the webhook service namespace.
  • Extend codegen verification to include config/crd/bases, so future generated CRD drift is caught.

Release Note

Restore conversion webhook configuration in Knative Operator CRDs generated for release manifests.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2026
@knative-prow knative-prow Bot requested review from houshengbo and matzew May 4, 2026 13:33
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.84%. Comparing base (a7151da) to head (1e0402a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2293   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          55       55           
  Lines        2478     2478           
=======================================
  Hits         1582     1582           
  Misses        777      777           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@houshengbo
Copy link
Copy Markdown
Contributor

/cherry-pick release-1.22
/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.22
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
@knative-prow knative-prow Bot merged commit 7f40b0b into knative:main May 4, 2026
22 checks passed
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@houshengbo: new pull request created: #2294

Details

In response to this:

/cherry-pick release-1.22
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants