Skip to content

Use official secretreader plugin#2306

Open
kahirokunn wants to merge 1 commit into
knative:mainfrom
kahirokunn:secretreader-access-provider
Open

Use official secretreader plugin#2306
kahirokunn wants to merge 1 commit into
knative:mainfrom
kahirokunn:secretreader-access-provider

Conversation

@kahirokunn
Copy link
Copy Markdown
Member

Fixes #

Background

The multicluster e2e setup previously built and used a test-only exec credential plugin because the official Cluster Inventory API access provider plugins were not available yet. The official secretreader and kubeconfig-secretreader plugin images have now been released, so this PR switches the examples and tests to use those published images directly.

Proposed Changes

  • Switch the multicluster access provider examples and e2e setup from the test-only self-built exec plugin to the official Cluster Inventory API secretreader plugin images.

Release Note

Multicluster access provider examples and e2e setup now use the official Cluster Inventory API secretreader plugin images.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot requested review from aliok and houshengbo May 28, 2026 02:21
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.84%. Comparing base (097eae0) to head (53e2f06).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          55       55           
  Lines        2478     2478           
=======================================
  Hits         1582     1582           
  Misses        777      777           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant