Skip to content

Defaulting/Mutating webhooks may have stale configurations when draining. #3338

@dprotaso

Description

@dprotaso

We have a test in serving that's flaky. knative/serving#16421

The test toggles a config map setting and then creates a service assuming the configuration changes have propagated to all components (webhooks and controllers)

The test started failing recently and the root cause is when a webhook is draining we are no longer receiving config map changes. Then when the service is created the the draining webhook handles the defaulting. Since it has the outdated config it fails creating the service.

Although the draining webhook shouldn't be receiving the request (we wait 30 seconds for the propagation) there's no guarantee so we should ensure our config map informers are still active during draining.

/assign @dprotaso

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions