adding constant for annotation#1424
Merged
knative-prow-robot merged 3 commits intoJun 22, 2020
Merged
Conversation
knative-prow-robot
added
the
size/XS
devguyio
reviewed
Jun 18, 2020
devguyio
left a comment
devguyio
left a comment
There was a problem hiding this comment.
Just a question , why call it annotation and not label?
| const ( | ||
| GroupName = "duck.knative.dev" | ||
|
|
||
| // AddressableDuckVersionAnnotation is the annotation we use to declare |
Contributor
There was a problem hiding this comment.
Agree, "Label" is a more term.
|
/assign |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
adding_constants_for_annotations
branch
from
e26516b to
38ca94e
Compare
|
/lgtm Waiting for more feedback from people who're more familiar with the code base |
Member
Author
antoineco
reviewed
Jun 22, 2020
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
fixes #1407