Skip to content

Conversation

@markusthoemmes
Copy link
Contributor

Changes

This got dropped inadvertently by #2248. This adds it back.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2282 (da88c1a) into main (d569db3) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   64.37%   64.44%   +0.07%     
==========================================
  Files         223      223              
  Lines        9608     9608              
==========================================
+ Hits         6185     6192       +7     
+ Misses       3145     3141       -4     
+ Partials      278      275       -3     
Impacted Files Coverage Δ
.../injection-gen/generators/reconciler_reconciler.go 0.00% <ø> (ø)
controller/controller.go 86.49% <0.00%> (+0.36%) ⬆️
test/gcs/mock/mock.go 93.54% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d569db3...da88c1a. Read the comment docs.

@markusthoemmes
Copy link
Contributor Author

/assign @mattmoor @dprotaso

@mattmoor
Copy link
Member

mattmoor commented Sep 9, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [markusthoemmes,mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit bfab3c8 into knative:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants